#4375 fix ios user redirect to set up password + update staging url for app association on native platforms

[dklymenk]

Details

This PR updates the list of associated domains with iOS app to make it identical with the one in AndroidManifest.xml
Also updates the staging url used for app association on both iOS and android.

Fixed Issues

$ #4375

Tests / QA Steps

prod url test for iOS only:

1. Logout
2. Input an email address for new account
3. Check the inbox, tap the link in the email
4. If the "Choose app to open with" modal appears, select "Expensify"
5. An app should open
6. Input the password
7. You should be automatically logged in

staging url test (ios and android):

1. Logout
2. Input an email address for new account
3. Check the inbox, long tap the link in the email. Tap "Copy" button.
4. Paste the link into any app that renders hyperlinks as clickable objects(I used calendar on ios and messages on android). Add staging to the URL, so it says staging.new.expenisify.com....
5. Tap the link.
6. If the "Choose app to open with" modal appears, select "Expensify"
7. An app should open
8. Input the password
9. You should be automatically logged in

Tested On

• iOS
• andorid

Screenshots

iOS

prod url:

4375-ios.mp4

staging url:

4375-ios-staging.mp4

Android

4357-andoid-staging.mp4

[AndrewGable]

Suggested change

	<string>applinks:staging.expensify.cash</string>
	<string>applinks:staging.new.expensify.com</string>

[AndrewGable]

Can you make this change on android too? Thanks: https://github.com/Expensify/App/blob/main/android/app/src/main/AndroidManifest.xml#L58

[dklymenk]

Hello, the requested changes have been implemented.

[AndrewGable]

Code looks great, can you add a note on how to test the latest commit e203903? Thanks.

[dklymenk]

Code looks great, can you add a note on how to test the latest commit e203903? Thanks.

Hello, I don't think you can test it. The magic link in emails is always for new.expensify.com, don't think you can generate one specifically for staging.

Or do you mean to test app association with any link, not magic link for password set/reset specifically?

[AndrewGable]

You can ask the tester to copy the new.expensify.com and paste into a note app. Then replace the new.expensify.com link with staging.new.expensify.com in a note app, then click the link. We do send staging links from our staging server, but this might be easiest for you and QA.

[dklymenk]

You can ask the tester to copy the new.expensify.com and paste into a note app. Then replace the new.expensify.com link with staging.new.expensify.com in a note app, then click the link. We do send staging links from our staging server, but this might be easiest for you and QA.

OK, I will add that later. Not on my laptop right now.

[dklymenk]

@AndrewGable Hello, I have updated the original post with additional videos and instructions. Also the title is updated.

[AndrewGable]

Looks great, thank you!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @AndrewGable in version: 1.0.83-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[botify]

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-08-24. 🎊

[OSBotify]

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅