[$250] iOS Chat - Main composer instead of edit composer is focused when tapping Edit comment

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.54-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Launch ND app.
2. Go to DM.
3. Send a message.
4. Tap on the composer.
5. Long press on the message sent in Step 3.
6. Tap Edit comment.

Expected Result:

The edit composer will be in focus.

Actual Result:

The main composer is in focus.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6645370_1729849780282.edit_message.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021850882933004334828
• Upwork Job ID: 1850882933004334828
• Last Price Increase: 2024-11-11

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

Production

P.1.MP4

[mjasikowski]

checking

[mjasikowski]

reproduced in dev

[mjasikowski]

Reverting #51477 does alter the behavior

Screen.Recording.2024-10-25.at.17.12.28.mov

[Beamanator]

@hungvu193 is helping look into reverting #51309 in slack - https://expensify.slack.com/archives/C01GTK53T8Q/p1729858771902939

[Beamanator]

Seems like the revert is not good enough - i'm trying to get my VM working to help debug iOS

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021850882933004334828

[melvin-bot]

Current assignee @hungvu193 is eligible for the External assigner, not assigning anyone new.

[Beamanator]

Hoping to get some help by making this external

[Beamanator]

Being looked at in https://expensify.slack.com/archives/C01GTK53T8Q/p1730120647371899?thread_ts=1729858771.902939&cid=C01GTK53T8Q 🙏

[289Adam289]

Hi! I am from SWM, an expert agency. I've looked at this issues and adding autoFocus prop seems to work but I will investigate root cause off the problem tomorrow.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Beamanator]

Discussed a bit in slack here, got some other opinions and overall agreed this isn't a big enough bug to block deploy

[Beamanator]

Unassigning myself & @hungvu193 b/c I believe this will be investigated deeply by SWM

[289Adam289]

Hi! Fix proposed by @shahinyan11 with setTimeout seems to work well. Apparently ios native side needs more time to change focus and proposed code ensures the callback will be executed after event stack is cleared. I am still not entirely sure what the root cause is.

[yuwenmemon]

@shahinyan11 does your solution also fix #51482

[melvin-bot]

@mjasikowski, @anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mjasikowski]

@289Adam289 will you investigate this further or shall we consider the workaround good enough and close this one out?

[289Adam289]

I think the workaround is good enough.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@mjasikowski, @anmurali 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[Jaeta01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS Chat - Main composer instead of edit composer is focused when tapping Edit comment

What is the root cause of that problem?

We implemented the isWindowReadyToFocus function differently for Android and other platforms. For other platforms, it resolves immediately.

What changes do you think we should make in order to solve the problem?

Update isWindowReadyToFocus to bellow

const isWindowReadyToFocus = () => new Promise(resolve => {
    setTimeout(resolve, 0);
});

What alternative solutions did you explore? (Optional)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[anmurali]

@mjasikowski - based on #51464 (comment), should we be closing this issue? I am OOO for a week, so if yes - can you close it? And if no, pls re-add the Bug label to get another BZ member assigned.