[HOLD for payment 2024-11-13] [$250] iOS - Search - Search input field does not auto focus

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.54-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch ND app or hybrid
2. Tap on the search icon on the top right

Expected Result:

Search input field will auto focus (production behavior)

Actual Result:

Search input field does not auto focus

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6645639_1729867786972.ScreenRecording_10-25-2024_22-47-54_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021851691945418827648
• Upwork Job ID: 1851691945418827648
• Last Price Increase: 2024-10-30
• Automatic offers:
• suneox | Reviewer | 104686746
• FitseTLT | Contributor | 104686747

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

Production:

RPReplay_Final1729868136.1.MP4

[Beamanator]

There seem to be multiple auto-focus bugs right now 🤔

[ChavdaSachin]

And they are specific to IOS.

[Beamanator]

@yuwenmemon since this is iOS-specific & related to focuses, I had a theory here what the cause could be - but maybe we could downgrade this to NAB?

[yuwenmemon]

Same root cause as: #51464

[Beamanator]

Agreed in slack this isn't a bad enough bug to block deploy

[yuwenmemon]

The similar issue seems to have a proposal that is promising, asked about this here: #51464 (comment)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021851691945418827648

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search input field does not auto focus

What is the root cause of that problem?

We use autoFocus prop to focus on the TextInput but it doesn't work as expected on IOS, maybe it's broken by the navigation transition or other transition.

App/src/components/Search/SearchRouter/SearchRouterInput.tsx

Lines 87 to 88 in aa6401d

	autoFocus={autoFocus}
	shouldDelayFocus={shouldDelayFocus}

What changes do you think we should make in order to solve the problem?

We should use useAutoFocusInput hook to focus on the TextInput and remove autoFocus and shouldDelayFocus. I checked this original PR for the reason we use autoFocus and shouldDelayFocus but when testing with useAutoFocusInput, it works well on mWeb chrome.

const {inputCallbackRef} = useAutoFocusInput();
ref={inputCallbackRef}

App/src/components/Search/SearchRouter/SearchRouterInput.tsx

Lines 87 to 88 in aa6401d

	autoFocus={autoFocus}
	shouldDelayFocus={shouldDelayFocus}

What alternative solutions did you explore? (Optional)

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

OS - Search - Search input field does not auto focus

What is the root cause of that problem?

The root cause is related with the patch applied in enable bridgeless pr (there is a discussion about it here)

What changes do you think we should make in order to solve the problem?

We can solve it by introducing delay in the focus, as we did for android,

App/src/components/Search/SearchRouter/SearchRouterInput.tsx

Line 88 in 664e657

shouldDelayFocus={shouldDelayFocus}

we are already introducing the delay for android here

App/src/libs/shouldDelayFocus/index.android.ts

Line 4 in 664e657

const shouldDelayFocus: ShouldDelayFocus = true;

so we should make it more general and include ios by changing the file to index.native.ts

What alternative solutions did you explore? (Optional)

[suneox]

@FitseTLT The RCA is correct, this issue only occurs at PR #48160 and update shouldDelayFocus for the native platform LGTM. So we can process with this proposal

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @yuwenmemon is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix- IOS - Search - Search input field does not auto focus #51859

If no regressions arise, payment will be issued on 2024-11-13. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment automatic offer (Reviewer)
• @FitseTLT requires payment automatic offer (Contributor)

[melvin-bot]

@suneox @twisterdotcom The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[suneox]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: I think there isn’t an offending PR here, as this is related to an infrastructure update included in this PR.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. N/A: this issue only happen on specific platform and auto focus doesn't break functionality

[twisterdotcom]

Payment Summary:

• @suneox paid $250 here (Reviewer)
• @FitseTLT paid $250 here (Contributor)