[Custom feeds] Land on the pending feed page after creating a second feed

[mountiny]

Reported in Slack here - check for more details

BUG: After adding a second card feed, you're supposed to land on the feed pending screen for the second feed. Instead you land back on the first feed. Shown in 🧵

Issue Owner

Current Issue Owner: @allgandalf

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[koko57]

I would like to help with this issue 🙂

[mountiny]

no payments will be needed

[koko57]

Working on this today. I've noticed that we have no loading state like we just applied in the Expensify card when making the call to API - maybe we should add one? And Error handling?

Screen.Recording.2024-10-29.at.19.05.56.mov

[koko57]

PR ready for review. #51719
For now - just landing on a proper page, I can cover the loading button and error handling in another PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] fix: show newly added feed as last selected feed #51719

If no regressions arise, payment will be issued on 2024-11-14. 🎊

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

@allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @lschurr you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @koko57 is from an agency-contributor and not due payment
• ROLE: @allgandalf paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@lschurr)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[lschurr]

Checked with @mountiny on this one - we will handle payments once the custom feeds project is done. @allgandalf could you work on the checklist? #51567 (comment)

[mountiny]

Yes, thanks! once the checklist is done, we can close

[allgandalf]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: Not a bug per say, we had the API written but never wrote the optimistic, failure and success data for that API.

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A, there is no offending PR, we never updated Onyx data for the API untill this issue.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• Company Cards enabled
• Have an existing feed for the policy

Test:

1. Add another new feed

Verify that : After adding a new feed the pending page is displayed for that newly added feed feed

Do we agree 👍 or 👎

[mountiny]

I think these tests will be handled by testing added by @joekaufmanexpensify for the project. I am going to close this as we will handle the payments together later for the project. Thanks for the rest for the checklist