[HOLD for payment 2024-12-17] [$250] Implement tests for reports that should be displayed in LHN

[OlimpiaZurek]

Tracking issue: #52031

Develop and implement unit tests to verify that the following report types are correctly displayed in the LHN:

1. Current report: Ensure the currently active report is highlighted appropriately.
2. Reports with violations (RBR): Confirm that reports with outstanding violations are displayed at the top of the list with a red dot indicator.
3. Reports requiring attention (GBR): Validate that reports needing user action display a green dot and are sorted correctly.
4. Report with draft comment: Check that reports with valid draft comments are indicated and sorted by name.
5. Pinned report: Verify that pinned reports are at the top of the list and sorted correctly.
6. Unread chat in Focus Mode: Ensure unread chats in focus mode are displayed with bold text.
7. Archived report in Default Mode: Confirm that archived reports are shown correctly in default mode, sorted by lastVisibleActionCreated.
8. Self-DM report: Verify that self-DM reports are included in the LHN when the corresponding setting is enabled.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021857141648927609929
• Upwork Job ID: 1857141648927609929
• Last Price Increase: 2024-11-21
• Automatic offers:
• ishpaul777 | Reviewer | 105084341
• mkzie2 | Contributor | 105084342

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[trjExpensify]

I take it I'm not needed here?

[melvin-bot]

@trjExpensify Huh... This is 4 days overdue. Who can take care of this?

[trjExpensify]

@OlimpiaZurek can you confirm what I'm doing with this? Should it be assigned to you? CC: @mountiny

[mountiny]

We are going to export this issue to the community once the tests framework is setup, that is what we are holding for

[trjExpensify]

Okay, so I'll drop it to Weekly for now.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021857141648927609929

[melvin-bot]

⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

[melvin-bot]

Upwork job price has been updated to $250

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[melvin-bot]

@trjExpensify, @OlimpiaZurek, @mountiny, @ishpaul777, @mkzie2 Eep! 4 days overdue now. Issues have feelings too...

[ishpaul777]

not overdue, i see we have draft PR now ^

[mkzie2]

@ishpaul777 The PR is ready. cc @OlimpiaZurek

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.73-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Add unit test for report should be displayed in LHN #53369

If no regressions arise, payment will be issued on 2024-12-17. 🎊

For reference, here are some details about the assignees on this issue:

• @OlimpiaZurek does not require payment (Contractor)
• @ishpaul777 requires payment automatic offer (Reviewer)
• @mkzie2 requires payment automatic offer (Contributor)

[melvin-bot]

@ishpaul777 @trjExpensify @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[ishpaul777]

not overdue just waiting payment

[trjExpensify]

Can you complete the checklist then please, @ishpaul777?

[ishpaul777]

this was not a bug and no ui changes added, we just added Automated tests for LHN items presence. No checklist necessary

[mountiny]

@ishpaul777 please add the checklist for all the issues, we try to automate the analytics so we can get better insight into the issues. You can describe what you said in the checklist template

[ishpaul777]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: Not a bug

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other: Logged in GH by Agency employee

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other: Agency Employee

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A not a bug

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A not a bug

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again

Not required this has no impact on ui

[trjExpensify]

Thanks! Payment summary as follows:

• $250 to @ishpaul777 for the C+ review
• $250 to @mkzie2 for the PR

Paid, closing!