-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Add unit test for report should be displayed in LHN #53369
Conversation
25bee06
to
8f29f00
Compare
3311f00
to
8bd5ccb
Compare
@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
On my radar, will review this tmrw |
Left one minor comment. Besides LGTM. |
@OlimpiaZurek You missed to submit the review, we can't see your comment 🫠 |
Reviewer Checklist
Screenshots/VideosAndroid: NativeNo Ui changes Android: mWeb ChromeNo Ui changes iOS: NativeNo Ui changes iOS: mWeb SafariNo Ui changes MacOS: Chrome / SafariNo Ui changes MacOS: DesktopNo Ui changes |
Co-authored-by: Ishpaul Singh <[email protected]>
@OlimpiaZurek I updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkzie2 Great, thank you! couple small suggestions
Co-authored-by: Vit Horacek <[email protected]>
Co-authored-by: Vit Horacek <[email protected]>
@mountiny I updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments
@mkzie2 Can you make that change please? |
Co-authored-by: Vit Horacek <[email protected]>
@mountiny Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.73-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.73-8 🚀
|
Explanation of Change
Implement unit tests to verify that the following report types are correctly displayed in the LHN:
Fixed Issues
$ #52032
PROPOSAL: #52032 (comment)
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop