-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2021-11-04] Add Instant tooltip & add tooltip to absolute positioned icons. #5347
Comments
Triggered auto assignment to @kevinksullivan ( |
Taking this issue on as we have already discussed this with Rajat in previous issue. @parasharrajat Can you please write up a formal proposal? I think this issue is not so important in terms of our deadline so I would say feel free to work on this, but we would not merge it before 9/24 most likely (unless we will decide we want this in the app). As it is a bit larger UI change, I would prefer to leave it for after the deadline in case some regressions show up. Please, excuse any delays which might occur with issue. Thank you for understanding 🙇 cc @shawnborton as you have proposed the instant switching of tooltips here #4499 (comment) |
Ah I simply mentioned that I noticed another app that did instant tooltip launching after at least one tooltip had been launched. Not necessarily suggesting we need to do the same here, but it might be a nice-to-have. |
No worries. I agree it is nice-to-have and Rajat quickly found a solution for it so it is worthy update. However, not a priority for n6 for sure. |
As per other issue, since we are now focusing on urgent N6 deadline, I will add |
Still on hold. |
This is still on hold, but @parasharrajat feel free to create the PR for this if you will have time and I can review. We will export this issue soon. |
PR is moving ahead 🎉 |
The PR is being reviewed, but still on hold. |
I realized, there was not |
@mountiny This is not exported yet. |
@parasharrajat Thank you for a bump, I will try to get this sorted. |
Triggered auto assignment to @MitchExpensify ( |
@MitchExpensify Can we please export this job on Upwork and hire @parasharrajat for it? Thank you very much for your help and time 🙇 |
On it! |
@parasharrajat Feel free to apply for the Upwork job! |
Thanks for the ping @mountiny. @dylanexpensify Done. |
@parasharrajat offer sent |
Lovely to work with yous ❤️ |
Thanks for grabbing while I was at SuiteWorld @dylanexpensify! I can take it from here (i.e. payment when ready) |
Woooot! No worries @MitchExpensify! |
Paid with bonus! |
@dylanexpensify This was on N6 Hold #5347 (comment). |
@MitchExpensify I think you missed the N6-hold bonus for this one. And also closing it. Thanks. |
Ah I see what happened @parasharrajat : This job was paid including the n6 hold bonus but I missed the reporting bonus paying that now! |
Paid! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
cc: @mountiny
This issue is created based on the discussion here.
Action Performed:
Expected Result:
Actual Result:
Workaround:
UX thing...
Platform:
Where is this issue occurring?
Version Number: v1.99.x
Reproducible in staging?: Yes
Reproducible in production?: yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: