Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2021-11-04] Add Instant tooltip & add tooltip to absolute positioned icons. #5347

Closed
parasharrajat opened this issue Sep 19, 2021 · 28 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@parasharrajat
Copy link
Member

parasharrajat commented Sep 19, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


cc: @mountiny

This issue is created based on the discussion here.

  1. It will add support for Instant tooltips Add Tooltips to all non-text actions/buttons in New Expensify #4499 (comment).
  2. I already added support for absolute positioned targets in Tooltip (Add edit icon #5346) & this issue is created to compensate that extra effort as well as add missing tooltips Add Tooltips to all non-text actions/buttons in New Expensify #4499 (comment).

Action Performed:

  1. Go to NewDot on the web.
  2. Hover over any icon that has a tooltip, observe that tooltip is shown with animation.
  3. Now move your cursor to other icons tooltip should be shown instantly without animation.
  4. Move away from your cursor from the tooltip target for > 1sec.
  5. Move back to any target and now tooltip should be shown with animation.

Expected Result:

  1. Instant effect explained in the Actions.
  2. Add missing tooltips.

Actual Result:

  1. every tooltip is shown with animation-delay.
  2. Missing tooltip from avatar pencil icon and etc.

Workaround:

UX thing...

Platform:

Where is this issue occurring?

  • Web
  • Desktop App

Version Number: v1.99.x
Reproducible in staging?: Yes
Reproducible in production?: yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation:

View all open jobs on GitHub

@parasharrajat parasharrajat added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Sep 19, 2021
@MelvinBot
Copy link

Triggered auto assignment to @kevinksullivan (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Sep 19, 2021
@mountiny mountiny self-assigned this Sep 19, 2021
@mountiny mountiny added Engineering External Added to denote the issue can be worked on by a contributor labels Sep 19, 2021
@mountiny
Copy link
Contributor

Taking this issue on as we have already discussed this with Rajat in previous issue.

@parasharrajat Can you please write up a formal proposal?

I think this issue is not so important in terms of our deadline so I would say feel free to work on this, but we would not merge it before 9/24 most likely (unless we will decide we want this in the app). As it is a bit larger UI change, I would prefer to leave it for after the deadline in case some regressions show up. Please, excuse any delays which might occur with issue. Thank you for understanding 🙇

cc @shawnborton as you have proposed the instant switching of tooltips here #4499 (comment)

@shawnborton
Copy link
Contributor

Ah I simply mentioned that I noticed another app that did instant tooltip launching after at least one tooltip had been launched. Not necessarily suggesting we need to do the same here, but it might be a nice-to-have.

@mountiny
Copy link
Contributor

No worries. I agree it is nice-to-have and Rajat quickly found a solution for it so it is worthy update. However, not a priority for n6 for sure.

@mountiny
Copy link
Contributor

As per other issue, since we are now focusing on urgent N6 deadline, I will add Weekly label, so MelvinBot does not ping us here. I will put it back to normal next week, when we can focus on this again! Thank you for understanding 🙇

@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Sep 21, 2021
@mountiny
Copy link
Contributor

Still on hold.

@mountiny
Copy link
Contributor

mountiny commented Oct 4, 2021

This is still on hold, but @parasharrajat feel free to create the PR for this if you will have time and I can review. We will export this issue soon.

@mountiny
Copy link
Contributor

PR is moving ahead 🎉

@mountiny
Copy link
Contributor

The PR is being reviewed, but still on hold.

@mountiny mountiny added Reviewing Has a PR in review n6-hold labels Oct 14, 2021
@mountiny
Copy link
Contributor

I realized, there was not n6-hold label on this issue. As this has not been requested part of n6 polish, we will wait with merging this code after the hold is lifted, just to avoid any problems before the release.

@parasharrajat
Copy link
Member Author

@mountiny This is not exported yet.

@mountiny mountiny removed the n6-hold label Oct 20, 2021
@mountiny
Copy link
Contributor

@parasharrajat Thank you for a bump, I will try to get this sorted.

@mountiny mountiny added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Oct 20, 2021
@MelvinBot
Copy link

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@MelvinBot MelvinBot added Daily KSv2 and removed Weekly KSv2 labels Oct 20, 2021
@mountiny
Copy link
Contributor

@MitchExpensify Can we please export this job on Upwork and hire @parasharrajat for it? Thank you very much for your help and time 🙇

@dylanexpensify
Copy link
Contributor

On it!

@dylanexpensify
Copy link
Contributor

@MelvinBot MelvinBot added Weekly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors and removed Daily KSv2 labels Oct 21, 2021
@mountiny mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 21, 2021
@mountiny
Copy link
Contributor

@parasharrajat Feel free to apply for the Upwork job!

@parasharrajat
Copy link
Member Author

Thanks for the ping @mountiny. @dylanexpensify Done.

@dylanexpensify
Copy link
Contributor

@parasharrajat offer sent

@mountiny
Copy link
Contributor

Lovely to work with yous ❤️

@MitchExpensify
Copy link
Contributor

Thanks for grabbing while I was at SuiteWorld @dylanexpensify! I can take it from here (i.e. payment when ready)

@dylanexpensify
Copy link
Contributor

Woooot! No worries @MitchExpensify!

@mountiny mountiny changed the title Add Instant tooltip & add tooltip to absolute positioned icons. [HOLD for payment 2021-11-04] Add Instant tooltip & add tooltip to absolute positioned icons. Oct 30, 2021
@parasharrajat
Copy link
Member Author

Ping for
image

@MitchExpensify
Copy link
Contributor

Paid with bonus!

@parasharrajat
Copy link
Member Author

parasharrajat commented Nov 6, 2021

@dylanexpensify This was on N6 Hold #5347 (comment).

@parasharrajat
Copy link
Member Author

parasharrajat commented Nov 8, 2021

@MitchExpensify I think you missed the N6-hold bonus for this one. And also closing it. Thanks.

@MitchExpensify
Copy link
Contributor

Ah I see what happened @parasharrajat : This job was paid including the n6 hold bonus but I missed the reporting bonus paying that now!

@MitchExpensify
Copy link
Contributor

Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants