Added tooltip sense & add missing tooltips #5733
Conversation
|
@mountiny please test it and let me know what do you think? If this looks good, then I will move to the next step of "adding missing tooltips to leftover actions". |
There was a problem hiding this comment.
@parasharrajat Tested this and love it! Great job Rajat 🎉
I have left just one styling comment to swap the order of the functions, otherwise code LGTM and feel free to continue with the other steps. Thank you for working on this improvement!
| function isActive() { | ||
| return active === true; | ||
| } | ||
|
|
||
| function deactivate() { | ||
| return debouncedDeactivate(); | ||
| } |
There was a problem hiding this comment.
NAB: A bit nitty-gritty, but I would keep the order alphabetical same as you have it in the export default on lines 23-25.
|
Great. Thanks. I will finish it asap. |
|
Thank you, I mean, it is not n6 polish so no need to rush on this one especially if you have some other issues, which are considered to be n6 polish. But feel free to go ahead for sure :) |
|
@mountiny Changes done and ready. |
There was a problem hiding this comment.
Code looks good to me, great job Rajat. As mentioned in the parent issue, I will keep this on hold for n6 as this was not requested as part on the polish and we want to avoid potential regressions as much as possible before the release.
Thank you very much for your work on this PR.
mountiny
changed the title
|
Hi @parasharrajat, The n6-hold was lifted so we can go ahead with this one. As this PR is touching more parts of code, I would prefer if we could merge |
mountiny
changed the title
|
@mountiny All set. |
|
@mountiny Ready for merge. |
There was a problem hiding this comment.
Thank you very much for your work on this and your patience @parasharrajat 🙇 Great job!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
Details
Fixed Issues
$ #5347
Tests | QA Steps
Tested On
Screenshots
Web
output_file.mp4
Mobile Web
Desktop
iOS
Android