Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Payment 2025-01-02] List of card-level export accounts are not displayed when using Intacct and vendor bills #54373

Closed
1 of 8 tasks
m-natarajan opened this issue Dec 19, 2024 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Dec 19, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): expense

Action Performed:

Prerequisite: User added a company card

  1. Navigate to company card
  2. Click the added cards to view the details page
  3. Click on export options and select Intacct

Expected Result:

List of card-level export accounts when using Intacct and vendor bills

Actual Result:

List of card-level export accounts are not displayed when using Intacct and vendor bills

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image - 2024-12-18T172259 954

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @strepanier03
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 19, 2024
Copy link

melvin-bot bot commented Dec 19, 2024

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@narefyev91
Copy link
Contributor

Hi, I’m Nicolay from Callstack and I would like to investigate this issue.

@dukenv0307
Copy link
Contributor

dukenv0307 commented Dec 19, 2024

@strepanier03 I'm working on WS Feed project so I can help take it as C+

@mountiny mountiny self-assigned this Dec 19, 2024
@mountiny mountiny moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Dec 19, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Dec 20, 2024
@melvin-bot melvin-bot bot changed the title List of card-level export accounts are not displayed when using Intacct and vendor bills [HOLD for payment 2025-01-02] List of card-level export accounts are not displayed when using Intacct and vendor bills Dec 26, 2024
Copy link

melvin-bot bot commented Dec 26, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 26, 2024
Copy link

melvin-bot bot commented Dec 26, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-02. 🎊

For reference, here are some details about the assignees on this issue:

  • @narefyev91 does not require payment (Contractor)
  • @dukenv0307 requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Dec 26, 2024

@dukenv0307 @strepanier03 @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
Copy link
Contributor

@dukenv0307 can you please complete the checklist and then we can close this to handle the payments

@garrettmknight garrettmknight moved this from Bugs and Follow Up Issues to Hold for Payment in [#whatsnext] #expense Dec 31, 2024
@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jan 2, 2025
Copy link

melvin-bot bot commented Jan 2, 2025

Payment Summary

Upwork Job

  • Contributor: @narefyev91 is from an agency-contributor and not due payment
  • Reviewer: @dukenv0307 owed $250 via NewDot

BugZero Checklist (@strepanier03)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@strepanier03
Copy link
Contributor

@dukenv0307 - Bump on the checklist here, thanks! I'll check this again on Monday.

@melvin-bot melvin-bot bot removed the Overdue label Jan 3, 2025
@strepanier03 strepanier03 changed the title [HOLD for payment 2025-01-02] List of card-level export accounts are not displayed when using Intacct and vendor bills [Payment 2025-01-02] List of card-level export accounts are not displayed when using Intacct and vendor bills Jan 3, 2025
@dukenv0307
Copy link
Contributor

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production
  • 2b. Reported on staging (deploy blocker)
  • 2c. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment:

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: N/A

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template
  • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Test:

  • Prerequisite: User added a company card
  1. Navigate to company card
  2. Click the added cards to view the details page
  3. Click on export options and select Intacct
  4. Verify that user sees list of available intacct accounts

Do we agree 👍 or 👎

@dukenv0307
Copy link
Contributor

@strepanier03 I completed the checklists

@melvin-bot melvin-bot bot added the Overdue label Jan 6, 2025
@strepanier03
Copy link
Contributor

strepanier03 commented Jan 6, 2025

Payment Summary

@melvin-bot melvin-bot bot removed the Overdue label Jan 6, 2025
@strepanier03
Copy link
Contributor

strepanier03 commented Jan 6, 2025

All right, @dukenv0307 - I've created the reg test GH and the payment summary is here.

You can request payment and I'm going to close this as complete.

@github-project-automation github-project-automation bot moved this from Hold for Payment to Done in [#whatsnext] #expense Jan 6, 2025
@dukenv0307
Copy link
Contributor

@strepanier03 I shouldn't be getting paid here, it belongs to WS feed project so will be paid later cc @mountiny

@mountiny
Copy link
Contributor

mountiny commented Jan 7, 2025

updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
Status: Done
Development

No branches or pull requests

5 participants