-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update link sharing description - @Akshavasalvi #5737
Comments
Triggered auto assignment to @francoisl ( |
Triggered auto assignment to @davidcardoza ( |
@davidcardoza (assigned with the copy label), do you think we should just go with |
With less of an emphasis on chat in our marketing, the link description copy can swing towards the features we are using. How about this?:
|
The description looks good. We need to update the header though too, perhaps just |
@francoisl There would be an Upwork job for posting this right? |
@akshayasalvi no Upwork post for this one sorry, it was a super quick change so I went ahead and did it. |
@francoisl I didn't mean for the fix. I meant for reporting it. |
(Keeping open for production QA) |
Triggered auto assignment to @adelekennedy ( |
@adelekennedy this has been fixed, but I added the External label so that we can compensate @akshayasalvi for reporting the issue. Thanks! |
@akshayasalvi just hired you in Upwork, once you accept I'll take care of payment! |
Done @adelekennedy :) |
@francoisldoes does this issue still need to be kept open for production QA? |
Yes, it's to remind me to test once the PRs are deployed to production, because we don't have a way to tag PRs for Applause to test on production at the moment. |
Perfect! |
Just realized I forgot to close this. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
Link description is updated with correct information.
Actual Result:
Link description is not update with current information.
Workaround:
N/A
Platform:
Where is this issue occurring?
Version Number: 1.1.7-0
Reproducible in staging?: N/A
Reproducible in production?: N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @akshayasalvi
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1633537098433700
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: