Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link sharing description - @Akshavasalvi #5737

Closed
isagoico opened this issue Oct 8, 2021 · 18 comments
Closed

Update link sharing description - @Akshavasalvi #5737

isagoico opened this issue Oct 8, 2021 · 18 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review

Comments

@isagoico
Copy link

isagoico commented Oct 8, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Copy this link https://new.expensify.com
  2. Paste it in a a app that has the preview link feature (for example: Whatsapp)

Expected Result:

Link description is updated with correct information.

Actual Result:

Link description is not update with current information.

Workaround:

N/A

Platform:

Where is this issue occurring?

  • Occurring outside of the app.

Version Number: 1.1.7-0

Reproducible in staging?: N/A
Reproducible in production?: N/A

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image

Expensify/Expensify Issue URL:

Issue reported by: @akshayasalvi
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1633537098433700

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@isagoico isagoico changed the title Update link sharing description Update link sharing description - @Akshavasalvi Oct 8, 2021
@francoisl francoisl added the Waiting for copy User facing verbiage needs polishing label Oct 8, 2021
@MelvinBot
Copy link

Triggered auto assignment to @davidcardoza (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

@francoisl
Copy link
Contributor

@davidcardoza (assigned with the copy label), do you think we should just go with Chat and payments are now the same thing. and simply remove Launching Summer 2021, join the waitlist to be first in line!?

@davidcardoza
Copy link
Contributor

davidcardoza commented Oct 8, 2021

With less of an emphasis on chat in our marketing, the link description copy can swing towards the features we are using. How about this?:

Corporate cards, reimbursements, receipt scanning, invoicing, and bill pay. One app, all free.

@francoisl
Copy link
Contributor

Example of what it would like in a twitter preview. Looks good - not too long so it doesn't get trimmed.

image

@francoisl francoisl added the Reviewing Has a PR in review label Oct 8, 2021
@davidcardoza
Copy link
Contributor

The description looks good. We need to update the header though too, perhaps just New Expensify for now

@botify botify closed this as completed Oct 11, 2021
@akshayasalvi
Copy link
Contributor

@francoisl There would be an Upwork job for posting this right?

@francoisl
Copy link
Contributor

@akshayasalvi no Upwork post for this one sorry, it was a super quick change so I went ahead and did it.

@akshayasalvi
Copy link
Contributor

@francoisl I didn't mean for the fix. I meant for reporting it.

@francoisl francoisl reopened this Oct 11, 2021
@francoisl francoisl removed the Waiting for copy User facing verbiage needs polishing label Oct 11, 2021
@botify botify closed this as completed Oct 11, 2021
@francoisl francoisl reopened this Oct 11, 2021
@francoisl
Copy link
Contributor

(Keeping open for production QA)

@puneetlath puneetlath added the External Added to denote the issue can be worked on by a contributor label Oct 11, 2021
@MelvinBot
Copy link

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@puneetlath
Copy link
Contributor

@adelekennedy this has been fixed, but I added the External label so that we can compensate @akshayasalvi for reporting the issue. Thanks!

@adelekennedy
Copy link

adelekennedy commented Oct 11, 2021

@akshayasalvi just hired you in Upwork, once you accept I'll take care of payment!

@akshayasalvi
Copy link
Contributor

Done @adelekennedy :)

@adelekennedy adelekennedy removed the Daily KSv2 label Oct 12, 2021
@adelekennedy
Copy link

@francoisldoes does this issue still need to be kept open for production QA?

@francoisl
Copy link
Contributor

Yes, it's to remind me to test once the PRs are deployed to production, because we don't have a way to tag PRs for Applause to test on production at the moment.

@adelekennedy
Copy link

Perfect!

@adelekennedy adelekennedy removed their assignment Dec 16, 2021
@francoisl
Copy link
Contributor

Just realized I forgot to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

9 participants