Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meta tag description #5740

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Update meta tag description #5740

merged 1 commit into from
Oct 11, 2021

Conversation

francoisl
Copy link
Contributor

cc @davidcardoza can you sign off the final copy please?

Details

Update the app description in the <meta> tags, for apps that show link previews.

Fixed Issues

$ #5737

Tests

  1. Launch ngrok so you can have a public-facing URL for NewDot
  2. Copy the URL in an app that does "previews", e.g. Whatsapp, Twitter, FB, etc.
  3. Make sure the preview shows the updated description, and not some text that mentions summer 2021.

QA Steps

  1. In WhatsApp or Twitter or FB, post a link to https://staging.new.expensify.com
  2. Make sure the preview description says "Corporate cards, reimbursements, receipt scanning, invoicing, and bill pay. One app, all free." like on the screenshot

image

@francoisl francoisl self-assigned this Oct 8, 2021
@francoisl francoisl requested a review from a team as a code owner October 8, 2021 23:47
@MelvinBot MelvinBot requested review from HorusGoul and removed request for a team October 8, 2021 23:47
@francoisl francoisl requested a review from davidcardoza October 8, 2021 23:47
@HorusGoul HorusGoul merged commit 73789a9 into main Oct 11, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @HorusGoul in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@mvtglobally
Copy link

@francoisl @davidcardoza @HorusGoul on what platforms should we QA this PR?

@francoisl
Copy link
Contributor Author

There are no tests in Expensify directly, it's only when linking to the site from WhatsApp, FB, Twitter, etc.

There was a follow-up PR to this one though, where we changed the title and preview image, which is only testable when that PR is deployed to production. So for now you can just check this one off, and I'll test the everything once it's deployed to production :)

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants