Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Production QA] Update app description title and preview image #5750

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

francoisl
Copy link
Contributor

@francoisl francoisl commented Oct 11, 2021

cc @davidcardoza

Details

Update the title property of the app's meta tags to New Expensify.

Fixed Issues

$ #5737 (comment)
Follow-up of #5740 that got merged too soon.

Tests

  1. Launch ngrok so you can have a public-facing URL for NewDot
  2. Copy the URL in an app that does "previews", e.g. Whatsapp, Twitter, FB, etc.
  3. Make sure the title of the app in the preview is New Expensify
  4. Make sure the logo in the preview is the "E" version with a blue background - not the "$" with a white background

QA Steps

  1. In WhatsApp or Twitter or FB, post a link to https://new.expensify.com
  2. Make sure the title of the app in the preview is New Expensify, like on the screenshot
  3. Make sure the logo in the preview is the "E" version with a blue background - not the "$" with a white background
    image

@francoisl francoisl self-assigned this Oct 11, 2021
@francoisl francoisl requested a review from a team as a code owner October 11, 2021 16:29
@MelvinBot MelvinBot requested review from roryabraham and removed request for a team October 11, 2021 16:30
@shawnborton
Copy link
Contributor

Can we update the preview image too while we're at it?

@shawnborton
Copy link
Contributor

How about this as a replacement:
og-preview-image

og-preview-image.png.zip

@francoisl francoisl changed the title Update app description title [Production QA] Update app description title Oct 11, 2021
@francoisl
Copy link
Contributor Author

We'll need to QA this on production because the image preview is hardcoded to use https://new.expensify.com/og-preview-image.png

Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but be aware @francoisl that Expensify/App does not have an internal or production QA checklist, so you have to personally remember to QA this on production.

@roryabraham
Copy link
Contributor

So feel free to self-merge once tests pass. BTW there is an issue to add an internalQA checklist #5195

@francoisl
Copy link
Contributor Author

Noted. I'll reopen the corresponding issue actually, it's assigned to me so I'll have something to remind me about the QA.

@francoisl francoisl merged commit 91964fd into main Oct 11, 2021
@francoisl francoisl deleted the francois-appDescriptionUpdate branch October 11, 2021 18:11
@francoisl francoisl changed the title [Production QA] Update app description title [Production QA] Update app description title and preview image Oct 11, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @francoisl in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico
Copy link

@francoisl I see production QA on this one. Should we check this off and then test once it hits prod?

@francoisl
Copy link
Contributor Author

Yes please!

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants