-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Production QA] Update app description title and preview image #5750
Conversation
Can we update the preview image too while we're at it? |
We'll need to QA this on production because the image preview is hardcoded to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but be aware @francoisl that Expensify/App does not have an internal or production QA checklist, so you have to personally remember to QA this on production.
So feel free to self-merge once tests pass. BTW there is an issue to add an internalQA checklist #5195 |
Noted. I'll reopen the corresponding issue actually, it's assigned to me so I'll have something to remind me about the QA. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @francoisl in version: 1.1.7-25 🚀
|
@francoisl I see production QA on this one. Should we check this off and then test once it hits prod? |
Yes please! |
🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀
|
cc @davidcardoza
Details
Update the
title
property of the app's meta tags toNew Expensify
.Fixed Issues
$ #5737 (comment)
Follow-up of #5740 that got merged too soon.
Tests
New Expensify
QA Steps
New Expensify
, like on the screenshot