Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android/IOS - Undefined showed instead of phone number after Pay by Venmo #6948

Closed
kbecciv opened this issue Dec 30, 2021 · 11 comments
Closed
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Dec 30, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Lunch the app
  2. Login with phone number account (Account A)
  3. Request money from another phone number account (Account B)
  4. Log in with Account B and tap on Pay button.
  5. Select Pay with Venmo

Expected Result:

User should be redirected to correct Venmo account

Actual Result:

User redirected to Venmo app with placeholder Undefined account

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.1.24.0

Reproducible in staging?: Yes

Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5391124_Screen_Recording_20211229-191708_Venmo.mp4

Expensify/Expensify Issue URL:

Issue reported by:

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Dec 30, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @nickmurray47 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mananjadhav
Copy link
Collaborator

@nickmurray47 I was fixing the Paypal undefined issue and I've added a fix for the Venmo as well (the phone number wasn't passed similar to Paypal address).

@nickmurray47
Copy link
Contributor

Yup, looks like that would solve the issue!

@parasharrajat
Copy link
Member

Great seems like the same solution fixes both.

@mvtglobally
Copy link

@mananjadhav @nickmurray47 Are we good to re-test?

@nickmurray47
Copy link
Contributor

I believe so, we applied the CP label so this should have gone directly to staging.

@mvtglobally
Copy link

Issue is fixed. Should I close it?

@nickmurray47
Copy link
Contributor

I'll close!

@nickmurray47 nickmurray47 removed the DeployBlockerCash This issue or pull request should block deployment label Dec 31, 2021
@marcaaron
Copy link
Contributor

I don't understand why this issue was not triaged, no Upwork created, and had a PR approved and merged. Seems like the process was not followed at all. Can someone explain why?

@parasharrajat
Copy link
Member

Actually, this issue was reported after a similar issue was created. Manan already created the PR for #6947 which indirectly solves thus there is no job was created for this and we decided to close this.

On the other hand, the process was not followed for #6947. You can raise the same flag there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants