[HOLD for payment 2022-01-11] PayPal.me link redirects to Undefined account

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Add a valid PayPal id
3. Click on any money request and select to Pay with PayPal.me
4. Check that link redirects to correct account

Expected Result:

User should be redirected to correct paypal account

Actual Result:

User redirected to Paypal with placeholder Undefined account

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.23-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @marcaaron
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640808489237000

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mananjadhav]

@mvtglobally This isn't reported by me. It was reported by @marcaaron. I am going to propose the solution which I mentioned in the #6889 (comment)

Proposed Solution:

In `IOUDetailsModal`, we're passing `submitterPayPalMeAddress` instead of `requestorPayPalMeAddress` (as required in `IOU.payIOUReport` function). The same needs to be updated for the phone number parameter as well.

[mvtglobally]

Adding deploy blocker label as we are unable to repro in PROD

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mananjadhav]

@TomatoToaster @madmax330 Based on the comment here I was supposed to work on this #6889 (comment) but it turned out to be a DeployBlocker. Hence I've raised the PR before going through the Upwork process.

[madmax330]

Removing the deploy blocker, the fix for this was deployed to staging and worked here: #6949

[mananjadhav]

@madmax330 I was hoping there'll be an Upwork job for this. Won't that be the case?

[madmax330]

Hmmm let me double check and get back to you

[MelvinBot]

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[marcaaron]

@TomatoToaster @madmax330 Based on the comment here I was supposed to work on this #6889 (comment) but it turned out to be a DeployBlocker. Hence I've raised the PR before going through the Upwork process.

@mananjadhav For future reference, please do not raise a PR unless you are specifically asked to do so. We have processes in place and when you skip them it causes confusion for our team. Thanks!

[MelvinBot]

Triggered auto assignment to @Jag96 (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mallenexpensify]

Job posted - https://www.upwork.com/jobs/~0109d9de5d37664776

@parasharrajat can you review @mananjadhav 's proposal above please?
#6947 (comment)

[parasharrajat]

I am sorry But there is nothing to review. @mananjadhav has already raised a PR which was merged and we wait for the regression period to be over and then release the payment. @mallenexpensify .

Another important note is that this issue was originally reported by Marc #6889 (comment)

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Paypal address and Venmo phone number #6949

If no regressions arise, payment will be issued on 2022-01-11. 🎊

[mallenexpensify]

oooof, confusing, thanks for the context @parasharrajat.
@Jag96 can you review for a sanity check? I think the issue is that @mananjadhav submitted the PR before being hired and assigned to this issue. If @mananjadhav should be considered hired for this can you assign @Jag96 ?

[Jag96]

Yup, looks like this issue was filed first, then #6948 was created as a deploy blocker, then @mananjadhav created the PR to fix #6948 before it was triaged.

#6948 is closed, and the feedback was given and received above, so I think we can assign @mananjadhav and payout for the fix after the 7-day regression. Assigning @mananjadhav.

[MelvinBot]

📣 @mananjadhav You have been assigned to this job by @Jag96!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mallenexpensify]

Thanks @Jag96 , to make sure I have the payment date right, which PR am I basing the '7 days without regression' on? This one? #6949

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.24-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Paypal address and Venmo phone number #6949

If no regressions arise, payment will be issued on 2022-01-11. 🎊

[Jag96]

@mallenexpensify yes I would use that PR

[mananjadhav]

Team, apologies for the confusion! 😥

[mallenexpensify]

No worries @mananjadhav we got it figured out. i think part of the confusion was based on the urgency of the deploy blocker, thanks for helping with that.
Title us updated to correctly reflect payment date (if no regressions)

[JmillsExpensify]

Thanks @mallenexpensify. I'll come back to this issue to handle payment as noted in the title.

[JmillsExpensify]

Handling payment to @mananjadhav for the PR based on this comment. Will close as soon as I close contract and confirm payment in Upwork.

[JmillsExpensify]

Processed payment/contract via Upwork, so I believe we're now set to close this issue out. Please contact me via Slack if there are any issues or something I missed!