Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Paypal address and Venmo phone number #6949

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

mananjadhav
Copy link
Collaborator

@mananjadhav mananjadhav commented Dec 30, 2021

Details

  • It fixes the Paypal address being redirected to undefined account
  • It also fixes the Venmo phone number being undefined

Fixed Issues

$ #6947
$ #6948

Tests

  • Tested redirect with Paypal.me address

QA Steps

Paypal

  1. Open the app
  2. Add a valid PayPal id
  3. Click on any money request and select to pay with PayPal.me
  4. Check that link redirects to the correct account

Venmo

  1. Open the app
  2. Login with phone number account (Account A)
  3. Request money from another phone number account (Account B)
  4. Login with Account B and tap on the Pay button.
  5. Select Pay with Venmo
  6. It should show up the valid phone number

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web-paypal-redirect.mov

Mobile Web

mweb-paypal-redirect.mov

Desktop

desktop-paypal-redirect.mov

iOS

ios-paypal-redirect.mov

Android

android-paypal-redirect.mov

@mananjadhav mananjadhav requested a review from a team as a code owner December 30, 2021 03:51
@MelvinBot MelvinBot requested review from TomatoToaster and removed request for a team December 30, 2021 03:51
@TomatoToaster
Copy link
Contributor

Applying CP-Staging since this fixes 2 DeployBlockers.

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@TomatoToaster TomatoToaster merged commit 9d41d8f into Expensify:main Dec 30, 2021
OSBotify pushed a commit that referenced this pull request Dec 30, 2021
fix: Paypal address and Venmo phone number
(cherry picked from commit 9d41d8f)
@marcaaron
Copy link
Contributor

If this fixes deploy blockers which PRs broke the original behavior?

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to staging by @TomatoToaster in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants