Add unit tests for common sidebar functionality #10619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgolen
commented
Aug 30, 2022
|
|
||
| if (this.props.inline) { | ||
| return ( | ||
| <View style={[StyleUtils.getWidthAndHeightStyle(width, height), styles.bgTransparent, styles.overflowVisible]}> | ||
| <View | ||
| accessibilityHint={`${this.props.src.name} Icon`} |
There was a problem hiding this comment.
This small refactoring done in this file was to add this prop, which allowed the Icon to be targetted by the unit tests. The rest of the changes in this file are just some cleaning up.
tgolen
changed the title
melvin-bot
bot
requested review from
danieldoglas
and removed request for
a team
luacmartins
reviewed
Aug 30, 2022
Co-authored-by: Carlos Martins <[email protected]>
luacmartins
approved these changes
Aug 31, 2022
15 tasks
|
🚀 Deployed to staging by @danieldoglas in version: 1.1.95-0 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issues
This is part of the refactoring needed in this issue: #7948
Tests
The unit tests were based on the tests written in these PRs:
#6084
#5317
QA Steps
Same as in these PRs:
#6084
#5317
cc @luacmartins