Add unit tests for common sidebar functionality

src/CONST.js

@@ -658,6 +658,7 @@ const CONST = {
         TYPE: {
             FREE: 'free',
             PERSONAL: 'personal',
+            CORPORATE: 'corporate',
         },
         ROLE: {
             ADMIN: 'admin',

src/ONYXKEYS.js

@@ -88,7 +88,6 @@ export default {
         REPORT_USER_IS_TYPING: 'reportUserIsTyping_',
         REPORT_IOUS: 'reportIOUs_',
         POLICY: 'policy_',
-        REPORTS_WITH_DRAFT: 'reportWithDraft_',
         REPORT_IS_COMPOSER_FULL_SIZE: 'reportIsComposerFullSize_',
         POLICY_MEMBER_LIST: 'policyMemberList_',
     },

src/components/Icon/index.js

@@ -41,27 +41,29 @@ class Icon extends PureComponent {
     render() {
         const width = this.props.small ? variables.iconSizeSmall : this.props.width;
         const height = this.props.small ? variables.iconSizeSmall : this.props.height;
-        const IconToRender = this.props.src;
-
-        const icon = (
-            <IconToRender
-                width={width}
-                height={height}
-                fill={this.props.fill}
-            />
-        );
 
         if (this.props.inline) {
             return (
-                <View style={[StyleUtils.getWidthAndHeightStyle(width, height), styles.bgTransparent, styles.overflowVisible]}>
+                <View
+                    accessibilityHint={`${this.props.src.name} Icon`}
+                    style={[StyleUtils.getWidthAndHeightStyle(width, height), styles.bgTransparent, styles.overflowVisible]}
+                >
                     <View style={[StyleUtils.getWidthAndHeightStyle(width, height), IconWrapperStyles, styles.pAbsolute]}>
                         {icon}
                     </View>
                 </View>
             );
         }
 
-        return icon;
+        return (
+            <View accessibilityHint={`${this.props.src.name} Icon`}>
+                <this.props.src
+                    width={width}
+                    height={height}
+                    fill={this.props.fill}
+                />
+            </View>
+        );
     }
 }
 

src/libs/OptionsListUtils.js

@@ -178,16 +178,6 @@ function getSearchText(report, reportName, personalDetailList, isChatRoomOrPolic
     return _.unique(searchTerms).join(' ');
 }
 
-/**
- * Determines whether a report has a draft comment.
- *
- * @param {Object} report
- * @return {Boolean}
- */
-function hasReportDraftComment(report) {
-    return lodashGet(report, 'hasDraft', false);
-}
-
 /**
  * If the report or the report actions have errors, return
  * CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR, otherwise an empty string.
@@ -234,7 +224,6 @@ function createOption(logins, personalDetails, report, reportActions = {}, {
     const isArchivedRoom = ReportUtils.isArchivedRoom(report);
     const hasMultipleParticipants = personalDetailList.length > 1 || isChatRoom || isPolicyExpenseChat;
     const personalDetail = personalDetailList[0];
-    const hasDraftComment = hasReportDraftComment(report);
     const hasOutstandingIOU = lodashGet(report, 'hasOutstandingIOU', false);
     const iouReport = hasOutstandingIOU
         ? lodashGet(iouReports, `${ONYXKEYS.COLLECTION.REPORT_IOUS}${report.iouReportID}`, {})
@@ -287,7 +276,7 @@ function createOption(logins, personalDetails, report, reportActions = {}, {
         phoneNumber: !hasMultipleParticipants ? personalDetail.phoneNumber : null,
         payPalMeAddress: !hasMultipleParticipants ? personalDetail.payPalMeAddress : null,
         isUnread: report ? report.unreadActionCount > 0 : null,
-        hasDraftComment,
+        hasDraftComment: lodashGet(report, 'hasDraft', false),
         keyForList: report ? String(report.reportID) : personalDetail.login,
         searchText: getSearchText(report, reportName, personalDetailList, isChatRoom || isPolicyExpenseChat),
         isPinned: lodashGet(report, 'isPinned', false),
@@ -424,7 +413,7 @@ function getOptions(reports, personalDetails, activeReportID, {
             return;
         }
 
-        const hasDraftComment = hasReportDraftComment(report);
+        const hasDraftComment = lodashGet(report, 'hasDraft', false);
         const iouReportOwner = lodashGet(report, 'hasOutstandingIOU', false)
             ? lodashGet(iouReports, [`${ONYXKEYS.COLLECTION.REPORT_IOUS}${report.iouReportID}`, 'ownerEmail'], '')
             : '';

src/pages/home/report/ReportActionsList.js

@@ -50,7 +50,7 @@ const propTypes = {
     mostRecentIOUReportSequenceNumber: PropTypes.number,
 
     /** Are we loading more report actions? */
-    isLoadingMoreReportActions: PropTypes.bool.isRequired,
+    isLoadingMoreReportActions: PropTypes.bool,
 
     /** Callback executed on list layout */
     onLayout: PropTypes.func.isRequired,
@@ -68,6 +68,7 @@ const propTypes = {
 const defaultProps = {
     personalDetails: {},
     mostRecentIOUReportSequenceNumber: undefined,
+    isLoadingMoreReportActions: false,
 };
 
 class ReportActionsList extends React.Component {

src/pages/home/sidebar/SidebarLinks.js

@@ -48,6 +48,9 @@ const propTypes = {
 
         /** Number of unread actions on the report */
         unreadActionCount: PropTypes.number,
+
+        /** Whether or not the report has a draft comment */
+        hasDraft: PropTypes.bool,
     })),
 
     /** List of users' personal details */
@@ -219,7 +222,7 @@ class SidebarLinks extends React.Component {
 
             // Because we are using map, we have to filter out any undefined reports. This happens if recentReports
             // does not have all the conversations in prevState.orderedReports
-                .filter(orderedReport => orderedReport !== undefined)
+                .compact()
                 .value();
 
         return {