Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only ask for last 4 digits of SSN #3745

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Only ask for last 4 digits of SSN #3745

merged 1 commit into from
Jun 25, 2021

Conversation

iwiznia
Copy link
Contributor

@iwiznia iwiznia commented Jun 24, 2021

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/166493

Tests

  • Make sure you have a bankAccount with addressName = Expensify Wallet and addressState = false (a silver wallet)
  • Go to /enable-payments in e.cash
  • Select any form, it will give you a link
  • Open that link in your phone and do the checks
  • Go back to the browser, you should be in this page:
    image
  • Complete everything
  • Check it works (disclaimer: I could not make the idology tests pass in dev, but they should work in stg/prod).

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

image

@iwiznia iwiznia requested a review from a team June 24, 2021 22:03
@iwiznia iwiznia self-assigned this Jun 24, 2021
@MelvinBot MelvinBot requested review from Dal-Papa and removed request for a team June 24, 2021 22:04
@@ -33,7 +33,7 @@ export default {
settings: 'Configuración',
termsOfService: 'Términos de servicio',
dob: 'Fecha de Nacimiento',
ssn: 'Número de Seguridad Social',
ssnLast4: 'Últimos 4 dígitos de su SSN',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: It was called Número de Seguridad Social and we changed it to SSN, is that cool ?

@Dal-Papa Dal-Papa merged commit fffa33b into main Jun 25, 2021
@Dal-Papa Dal-Papa deleted the ionatan_last4ssn branch June 25, 2021 08:32
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.73-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico
Copy link

@iwiznia Hello! Not sure if we're able to test this PR. We have not been included in the wallet beta yet and we're still unable to add bank accounts via e.cash. Can you check if this is internal?

@iwiznia
Copy link
Contributor Author

iwiznia commented Jun 28, 2021

This needs another PR that's not deployed yet, so no QA.

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.74-0🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants