Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only ask for last 4 digits of SSN #3745

Merged
merged 1 commit into from
Jun 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/languages/en.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export default {
settings: 'Settings',
termsOfService: 'Terms of Service',
dob: 'Date of Birth',
ssn: 'Social Security Number',
ssnLast4: 'Last 4 Digits of SSN',
addressNoPO: 'Address (no P.O. boxes)',
companyAddressNoPO: 'Company Address (no P.O. boxes)',
city: 'City',
Expand Down Expand Up @@ -379,7 +379,6 @@ export default {
isMyDataSafe: 'Is my data safe?',
onFidoConditions: 'By continuing with the request to add this bank account, you confirm that you have read, understand and accept ',
onFidoFacialScan: 'Onfido’s Facial Scan Policy and Release',
ssnLast4: 'Last 4 Digits of SSN',
isControllingOfficer: 'I am authorized to use my company bank account for business spend',
isControllingOfficerError: 'You must be a controlling officer with authorization to operate the business bank account.',
},
Expand Down
3 changes: 1 addition & 2 deletions src/languages/es.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export default {
settings: 'Configuración',
termsOfService: 'Términos de servicio',
dob: 'Fecha de Nacimiento',
ssn: 'Número de Seguridad Social',
ssnLast4: 'Últimos 4 dígitos de su SSN',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: It was called Número de Seguridad Social and we changed it to SSN, is that cool ?

addressNoPO: 'Dirección (sin Apartado Postal)',
companyAddressNoPO: 'Dirección de la Empresa (sin Apartado Postal)',
city: 'Ciudad',
Expand Down Expand Up @@ -391,7 +391,6 @@ export default {
isMyDataSafe: '¿Están seguros mis datos?',
onFidoConditions: 'Al continuar con la solicitud de añadir esta cuenta bancaria, confirma que ha leído, entiende y acepta ',
facialScan: 'la política de reconocimiento facial y la exención de Onfido',
ssnLast4: 'Últimos 4 dígitos de su SSN',
isControllingOfficer: 'Estoy autorizado a utilizar la cuenta bancaria de mi compañía para gastos de empresa',
isControllingOfficerError: 'Debe ser un oficial controlador con autorización para operar la cuenta bancaria de la compañía',
},
Expand Down
6 changes: 5 additions & 1 deletion src/pages/EnablePayments/AdditionalDetailsStep.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,10 @@ class AdditionalDetailsStep extends React.Component {
fieldName: 'dob',
},
{
label: props.translate('common.ssn'),
label: props.translate('common.ssnLast4'),
fieldName: 'ssn',
maxLength: 4,
keyboardType: 'number-pad',
},
];

Expand Down Expand Up @@ -133,6 +135,8 @@ class AdditionalDetailsStep extends React.Component {
errorText={errorFields.includes(field.fieldName)
? `${field.label} ${this.requiredText}`
: ''}
// eslint-disable-next-line react/jsx-props-no-spreading
{..._.omit(field, ['label', 'fieldName'])}
/>
))}
</ScrollView>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/ReimbursementAccount/IdentityForm.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ const IdentityForm = ({
onChangeText={val => onFieldChange('dob', val)}
/>
<TextInputWithLabel
label={`${translate('requestorStep.ssnLast4')}`}
label={`${translate('common.ssnLast4')}`}
containerStyles={[styles.mt4]}
value={ssnLast4}
onChangeText={val => onFieldChange('ssnLast4', val)}
Expand Down