Expense chat doesn't scroll to bottom when send message or money request #42030

samilabud · 2024-05-12T23:51:24Z

Details

Fixed Issues

$ #40594
PROPOSAL: #40594 (comment)

Tests

Go to https://staging.new.expensify.com/
Log in
Create a new WS or go to 1:1 chat
Navigate to WS chat and send a new comment, or split expense or submit expense, etc.
The scroll should be down automatically

Verify that no errors appear in the JS console

Offline tests

Go to https://staging.new.expensify.com/
Log in
Create a new WS or go to 1:1 chat
Navigate to WS chat and send a new comment, or split expense or submit expense, etc.
The scroll should be down automatically

QA Steps

Try the next online and offline:

Go to https://staging.new.expensify.com/
Log in
Create a new WS or go to 1:1 chat
Navigate to WS chat and send a new comment, or split expense or submit expense, etc.
The scroll should be down automatically

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.-.Autoscroll.test.mp4

Android: mWeb Chrome

Chrome.Android.-.Autoscroll.test.mp4

iOS: Native

IPhone.-.Autoscroll.test.mp4

iOS: mWeb Safari

Safari.Iphone.-.Autoscroll.test.mp4

MacOS: Chrome / Safari

MAC.Chrome.-.Autoscroll.test.mp4

MacOS: Desktop

MAC.Desktop.-.Autoscroll.test.mp4

… in two devices at the same time

melvin-bot · 2024-05-12T23:51:29Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2024-05-14T13:56:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-05-14.at.7.56.29.PM.mov

Screen.Recording.2024-05-14.at.7.57.38.PM.mov

Screen.Recording.2024-05-14.at.8.00.31.PM.mov

Screen.Recording.2024-05-14.at.8.01.53.PM.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

allroundexperts · 2024-05-14T15:11:12Z

@samilabud This happened while I was testing. Trying to see if I can reproduce.

Screen.Recording.2024-05-14.at.8.09.11.PM.mov

allroundexperts · 2024-05-14T15:23:28Z

The above issue seems to be happening intermittently. Specifically, it has something to do with sending messages in offline mode when you have sent the previous message in online mode.

samilabud · 2024-05-14T15:24:56Z

The above issue seems to be happening intermittently. Specifically, it has something to do with sending messages in offline mode when you have sent the previous message in online mode.

Hey @allroundexperts could you try again? I think this happened because of a threshold validation I have added in the last commit.

allroundexperts · 2024-05-14T15:44:01Z

@samilabud Now, its even more broken.

Screen.Recording.2024-05-14.at.8.42.55.PM.mov

samilabud · 2024-05-14T18:30:11Z

@samilabud Now, its even more broken.

Screen.Recording.2024-05-14.at.8.42.55.PM.mov

Hi @allroundexperts, I let the things as the same and did merged with master branch, also did rebuild of everything (graddle, npm, removed node_modules, etc) and tried to reproduced it:

Autoscroll.-.Test.mp4

Am I missing something? The only weird thing I've seen is that sometimes the server time is different from our optimistic time (different in hours).

allroundexperts · 2024-05-15T16:57:38Z

Hm... is that causing the issue I mentioned above?

samilabud · 2024-05-15T17:04:09Z

Hm... is that causing the issue I mentioned above?

I can't reproduce what you mentioned above 🥲, however when there are time differences the autoscroll do not going to work, sometimes I saw that behavior when I was debugging, then expensify services would stop responding for a few seconds and then fix itself. And this day, this was happening a lot (also in this thread many people was presenting issues).

BTW I would like to know the conditions/steps to reproduce the issue that you mentioned above.

allroundexperts · 2024-05-15T19:46:35Z

BTW I would like to know the conditions/steps to reproduce the issue that you mentioned above.

I don't have the exact steps. I spent like 40 minutes yesterday trying to reproduce but it happened randomly without any definite steps.

This makes me think that it might be related to following:

however when there are time differences the autoscroll do not going to work

@mountiny Do you think we should proceed here with this fix? It's a lot better than before, but I'm still seeing this issue happening some times (Almost 1 in 20 times).

mountiny · 2024-05-20T19:41:09Z

Hmm I have not seen this bug before #42030 (comment)

Is this reproducible in main too? I feel like it might be related to these changes we should make sure its fixed

hoangzinh · 2024-08-15T08:52:53Z

Hi @samilabud can you close this PR as it has been fixed in another PR? Thank you.

samilabud added 5 commits May 7, 2024 22:37

Fixed optimistic logic when sending messages

4a446e9

Merge branch 'main' into message_not_autoscroll_40594

be8f3bc

Merge branch 'main' into message_not_autoscroll_40594

87009a7

Removed console log

b74069b

Added validation to autoscroll to top threshold, this fix when we are…

7b006c3

… in two devices at the same time

samilabud requested a review from a team as a code owner May 12, 2024 23:51

melvin-bot bot requested review from hoangzinh and removed request for a team May 12, 2024 23:51

mountiny assigned samilabud May 13, 2024

mountiny mentioned this pull request May 13, 2024

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] CRITICAL: [UX Reliability] [$1000] Chat - Chat does not scroll down when sending messages #40724

Closed

6 tasks

Merge branch 'main' into message_not_autoscroll_40594

9336e23

samilabud force-pushed the message_not_autoscroll_40594 branch from 948a3ee to 9336e23 Compare May 14, 2024 18:24

samilabud mentioned this pull request May 18, 2024

[HOLD for payment 2024-06-06] CRITICAL: [$250] Clicking New messages when there are no new messages inexplicably calls OpenReport, and doesn't clear #41188

Closed

6 tasks

samilabud mentioned this pull request Jun 5, 2024

[HOLD #40724] [$250] IOU –Expense chat doesn't scroll to bottom when send message and create second money request #40594

Closed

6 tasks

mountiny closed this Aug 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expense chat doesn't scroll to bottom when send message or money request #42030

Expense chat doesn't scroll to bottom when send message or money request #42030

samilabud commented May 12, 2024 •

edited

Loading

melvin-bot bot commented May 12, 2024

allroundexperts commented May 14, 2024 •

edited

Loading

allroundexperts commented May 14, 2024

allroundexperts commented May 14, 2024

samilabud commented May 14, 2024

allroundexperts commented May 14, 2024

samilabud commented May 14, 2024 •

edited

Loading

allroundexperts commented May 15, 2024

samilabud commented May 15, 2024 •

edited

Loading

allroundexperts commented May 15, 2024

mountiny commented May 20, 2024

hoangzinh commented Aug 15, 2024 •

edited

Loading

Expense chat doesn't scroll to bottom when send message or money request #42030

Expense chat doesn't scroll to bottom when send message or money request #42030

Conversation

samilabud commented May 12, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 12, 2024

allroundexperts commented May 14, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented May 14, 2024

allroundexperts commented May 14, 2024

samilabud commented May 14, 2024

allroundexperts commented May 14, 2024

samilabud commented May 14, 2024 • edited Loading

allroundexperts commented May 15, 2024

samilabud commented May 15, 2024 • edited Loading

allroundexperts commented May 15, 2024

mountiny commented May 20, 2024

hoangzinh commented Aug 15, 2024 • edited Loading

samilabud commented May 12, 2024 •

edited

Loading

allroundexperts commented May 14, 2024 •

edited

Loading

samilabud commented May 14, 2024 •

edited

Loading

samilabud commented May 15, 2024 •

edited

Loading

hoangzinh commented Aug 15, 2024 •

edited

Loading