Handle context menu format command #54983

bernhardoj · 2025-01-09T05:03:29Z

Explanation of Change

Fixed Issues

$ #53145
PROPOSAL: #53145 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Only for iOS mWeb Safari and Web Safari

Open any chat
Type anything on the composer
Select some text on the composer
Right-click or long-press to open the web context menu
Select Format (iOS mWeb) or Font (Web Safari)
Select Bold and Italic
Verify the bold and italic markdown is added

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

melvin-bot · 2025-01-09T05:03:34Z

@dubielzyk-expensify @mananjadhav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dubielzyk-expensify · 2025-01-09T05:09:23Z

Ohh that is neat! Looks good to me 😄 I'll let @Expensify/design do a double/triple check

shawnborton · 2025-01-09T08:25:06Z

This looks good to me too! Have we considered also supporting things like Command + B to bold selected text, or Command + I to italicize selected text?

dannymcclain · 2025-01-09T14:05:19Z

Yeah looks rad!

Have we considered also supporting things like Command + B to bold selected text, or Command + I to italicize selected text?

I've asked about this before as well—I think it would be SO lovely to have these common keyboard shortcuts! Maybe not as part of this PR, but we should definitely consider adding it at some point.

mananjadhav · 2025-01-09T20:01:22Z

@Expensify/design @bernhardoj What do you think the behavior should be if the user clicks on the selected twice? ie

User types Hello World
Selects the text and clicks Format > Bold.
Text updates to markdown *Hello World*.
What should the expected behavior be when user selects *Hello World* and clicks on Format > Bold again. Currently it updates to **Hello World** ends up as * Hello World *
What happens if the user selects only partial text: World, then the current behavior is *Hello *World** ends up * Hello World *

web-ios-formatting.mov

dannymcclain · 2025-01-09T20:14:20Z

Great questions. I think Github handles those situations pretty well.

CleanShot.2025-01-09.at.14.08.46.mp4

What should the expected behavior be when user selects Hello World and clicks on Format > Bold again. Currently it updates to **Hello World**

I think it would be ideal if it reverted back to unbolded *Hello world* -> Hello world

What happens if the user selects only partial text: World, then the current behavior is *Hello *World**

This one I think is fine as is... I don't really know what else we could be expected to do in this situation.

shawnborton · 2025-01-09T20:18:29Z

Yup, agree with Danny

src/components/RNMarkdownTextInput.tsx

mananjadhav · 2025-01-09T20:22:01Z

Thanks for the quick response.

@bernhardoj can you please take a look the expected behavior and the PR comment?

dubielzyk-expensify · 2025-01-10T00:48:01Z

Agree with y'all and would love to see those keyboard shortcuts make its way in as well 😄

bernhardoj · 2025-01-10T02:26:16Z

What do you think the behavior should be if the user clicks on the selected twice? ie

We already discussed this before on the live markdown PR here

mananjadhav · 2025-01-10T05:00:04Z

I understand but I think this should be an implementation detail and bought this up here again. @Expensify/design can you take a look at @bernhardoj's comment?

shawnborton · 2025-01-10T07:34:53Z

Sorry, but what is the exact question you need help getting answered?

mananjadhav · 2025-01-10T08:03:21Z

The comment from @bernhardoj highlighted that we will use WhatsApp behavior ie not toggling bold and un-bold. But the previous comments mention we’ll toggle. So confirming the expected behavior again.

shawnborton · 2025-01-10T08:10:05Z

Got it. Per @dannymcclain's comment, I think he is suggesting that we should do the toggle behavior if it's possible.

dannymcclain · 2025-01-10T14:38:11Z

Yeah that is what I was suggesting. It sounds like in that other PR they decided we could handle the un-formatting in a follow up/enhancement to this. I honestly don't feel too strongly, I'm just saying the ideal behavior would be to un-format the selection if they selected the option again.

shawnborton · 2025-01-10T15:56:18Z

Cool cool, I can totally get down with that.

mananjadhav · 2025-01-10T17:32:24Z

I think we should do this as a follow up. I don't see a straight forward solution and best to consider it along with the keyboard shortcuts.

mananjadhav · 2025-01-10T17:34:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

web-ios-formatting.mov

MacOS: Chrome / Safari

web-formatting-context-menu.mov

MacOS: Desktop

mananjadhav

Approving the changes after the testing and review.

@blimpich one non-blocking comment for your review and @dubielzyk-expensify pending design approval.

blimpich · 2025-01-10T18:18:54Z

I think we should do this as a follow up. I don't see a straight forward solution and best to consider it along with the keyboard shortcuts.

Yeah I think ideally we should've been more clear in the proposal stage as to what the ideal design is before selecting a proposal. We're already here though so I think lets just move forward with this and do a follow up (I'll create a issue) to do the toggle and keyboard shortcuts. I'll also add @dubielzyk-expensify to that issue so that they can audit the design.

OSBotify · 2025-01-10T18:29:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-11T03:37:42Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.84-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

mountiny · 2025-01-11T19:19:40Z

package.json

@@ -76,7 +76,7 @@
  },
  "dependencies": {
    "@dotlottie/react-player": "^1.6.3",
-    "@expensify/react-native-live-markdown": "0.1.210",
+    "@expensify/react-native-live-markdown": "0.1.215",


@mananjadhav Please make sure to build and test changes with the hybrid app setup, this change is causing hybrid app build to fail as there is a patch that has to be updated https://github.com/Expensify/App/actions/runs/12720655080/job/35462635073

github-actions · 2025-01-14T13:36:26Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.84-7 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-14T13:58:24Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.84-7 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

handle context menu format command

1106916

bernhardoj requested a review from a team as a code owner January 9, 2025 05:03

melvin-bot bot requested review from dubielzyk-expensify and mananjadhav and removed request for a team January 9, 2025 05:03

mananjadhav reviewed Jan 9, 2025

View reviewed changes

src/components/RNMarkdownTextInput.tsx Show resolved Hide resolved

mananjadhav approved these changes Jan 10, 2025

View reviewed changes

melvin-bot bot requested a review from blimpich January 10, 2025 17:35

blimpich assigned bernhardoj Jan 10, 2025

blimpich approved these changes Jan 10, 2025

View reviewed changes

blimpich merged commit d7a0088 into Expensify:main Jan 10, 2025
21 of 25 checks passed

github-actions bot mentioned this pull request Jan 11, 2025

Deploy Checklist: New Expensify 2025-01-11 #55109

Closed

39 tasks

shubham1206agra mentioned this pull request Jan 11, 2025

[CP Staging] Revert "Handle context menu format command" #55127

Merged

mountiny reviewed Jan 11, 2025

View reviewed changes

melvin-bot bot mentioned this pull request Jan 14, 2025

[HOLD #55115][$250] mWeb - Compose box- Selected text isn't applied format #53145

Open

8 tasks

Skalakid mentioned this pull request Jan 24, 2025

[CP Staging] Bump react-native-live-markdown version to 0.1.221 #55509

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle context menu format command #54983

Handle context menu format command #54983

bernhardoj commented Jan 9, 2025

melvin-bot bot commented Jan 9, 2025

dubielzyk-expensify commented Jan 9, 2025

shawnborton commented Jan 9, 2025

dannymcclain commented Jan 9, 2025

mananjadhav commented Jan 9, 2025 •

edited

Loading

dannymcclain commented Jan 9, 2025

shawnborton commented Jan 9, 2025

mananjadhav commented Jan 9, 2025

dubielzyk-expensify commented Jan 10, 2025

bernhardoj commented Jan 10, 2025

mananjadhav commented Jan 10, 2025

shawnborton commented Jan 10, 2025

mananjadhav commented Jan 10, 2025

shawnborton commented Jan 10, 2025

dannymcclain commented Jan 10, 2025

shawnborton commented Jan 10, 2025

mananjadhav commented Jan 10, 2025

mananjadhav commented Jan 10, 2025

mananjadhav left a comment

blimpich commented Jan 10, 2025

OSBotify commented Jan 10, 2025

github-actions bot commented Jan 11, 2025

mountiny Jan 11, 2025

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

Handle context menu format command #54983

Handle context menu format command #54983

Conversation

bernhardoj commented Jan 9, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 9, 2025

dubielzyk-expensify commented Jan 9, 2025

shawnborton commented Jan 9, 2025

dannymcclain commented Jan 9, 2025

mananjadhav commented Jan 9, 2025 • edited Loading

dannymcclain commented Jan 9, 2025

shawnborton commented Jan 9, 2025

mananjadhav commented Jan 9, 2025

dubielzyk-expensify commented Jan 10, 2025

bernhardoj commented Jan 10, 2025

mananjadhav commented Jan 10, 2025

shawnborton commented Jan 10, 2025

mananjadhav commented Jan 10, 2025

shawnborton commented Jan 10, 2025

dannymcclain commented Jan 10, 2025

shawnborton commented Jan 10, 2025

mananjadhav commented Jan 10, 2025

mananjadhav commented Jan 10, 2025

Reviewer Checklist

Screenshots/Videos

mananjadhav left a comment

Choose a reason for hiding this comment

blimpich commented Jan 10, 2025

OSBotify commented Jan 10, 2025

github-actions bot commented Jan 11, 2025

mountiny Jan 11, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

mananjadhav commented Jan 9, 2025 •

edited

Loading