[CP Staging] Bump react-native-live-markdown version to 0.1.221 #55509

Skalakid · 2025-01-21T09:29:44Z

Explanation of Change

Important

This PR should be merged together with the OldDot changes https://github.com/Expensify/Mobile-Expensify/pull/13373

This PR bump the Live Markdown library version to 0.1.221.

MOBILE-EXPENSIFY: 13373

Fixed Issues

$ #55115
PROPOSAL:

Tests

Emoji splitting

Apply the changes from the OldDot PR (rename the live markdown patch file) so you can successfully run npm i
Open the app
Open any chat.
Compose a message with two markdowns, being the second one "Bold" and an emoji. Example: :smile
Check the bold markdown behaviour with this action.

With quote markdown, url text on tapping enter key not moved to next line

Open chat
Enter > jsjjd.com
Send the message
Edit the message
Tap enter key and try to make url text into two lines

Compose box- Selected text isn't applied format

At compose box of any conversation, type 1 line
Select all text, choose Format: Bold and send message
Type another line
Select all text, choose Format: Italic and send message
Type another line
Select all text, choose Format: Underline and send message. We don't support underline text, nothing should be applied

Context menu format command

Type anything on the composer
Select some text on the composer
Right-click or long-press to open the web context menu
Select Format (iOS mWeb) or Font (Web Safari)
Select Bold and Italic
Verify the bold and italic markdown is added

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-23.at.10.01.06.mov

Android: mWeb Chrome

chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

Screen.Recording.2025-01-21.at.13.46.06.mov

…1.221

melvin-bot · 2025-01-21T12:41:00Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2025-01-21T13:15:50Z

@sobitneupane Please, make sure to test the hybrid app build with the associated oldApp PR

sobitneupane

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-23.at.16.13.20.mov

Android: mWeb Chrome

Screen.Recording.2025-01-22.at.15.49.34.mov

iOS: Native

Screen.Recording.2025-01-22.at.19.24.51.mov

iOS: mWeb Safari

Screen.Recording.2025-01-22.at.16.20.24.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-22.at.15.35.23.mov

MacOS: Desktop

Screen.Recording.2025-01-22.at.16.10.44.mov

github-actions · 2025-01-22T14:15:33Z

🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here.

github-actions · 2025-01-22T14:21:30Z

🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here.

mountiny · 2025-01-22T14:23:26Z

Jus testing something, dont mind me

github-actions · 2025-01-22T14:29:32Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

sobitneupane

I am experiencing an issue while testing on Android. The standalone app keeps crashing and the hybrid app keeps reloading on the splash screen after signing in. I faced the same issue earlier as well. So, I don't think it's related to the changes.

There are some git differences in Podfile.lock in the Mobile-Expensify submodule. Apart from that, changes test well.

sobitneupane · 2025-01-22T18:31:47Z

I am experiencing an issue while testing on Android. The standalone app keeps crashing and the hybrid app keeps reloading on the splash screen after signing in. I faced the same issue earlier as well. So, I don't think it's related to the changes.

It runs without any issue on the main branch. @Skalakid Could you please double check it on your end?

…1.221

Skalakid · 2025-01-23T09:07:56Z

@sobitneupane I merged the latest main and the problem with building Android should be fixed now

Video

Screen.Recording.2025-01-23.at.10.01.06.mov

sobitneupane · 2025-01-23T10:31:59Z

@Skalakid Thanks for the update. I was able to successfully build and run the hybrid app.

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

shubham1206agra · 2025-01-23T18:36:13Z

@Skalakid Please add test steps from #54522 #53145

Kicu · 2025-01-24T07:37:50Z

@shubham1206agra

This bump will include changes from new short mention. Will it break existing short mention mechanism since Expensify-common was not merged yet?

As far as short-mentions are concerned, merging this bump should not break anything. My changes only added handling to LM for the new short-mention tag, that could come from ExpensiMark.

If the tag never appears then nothing will happen. Once expensify-common is merged, then RNLM will be ready to handle it.

Skalakid · 2025-01-24T07:45:57Z

rightly pointed out that these changes were not brought back. Are they not needed anymore? #55127 (files)

@mountiny brought back the changes that were reverted (588bb46)

…1.221

Skalakid · 2025-01-24T14:27:01Z

@mountiny @grgia All things added, let's merge it to avoid conflicts and unblock other issues :D

…1.221

mountiny · 2025-01-24T18:23:42Z

https://github.com/Expensify/Mobile-Expensify/pull/13373 merged

mountiny · 2025-01-24T18:39:53Z

Alright, sorry, after https://github.com/Expensify/Mobile-Expensify/pull/13373 was merged I realized that:

if we CP another App PR to staging, the main from Mobile-Expensify will be used and that PR will go to staging
that would, however, make the staging build not working because the oldApp change will need this PR
we would have to CP this PR to staging too, however, the QA is 91% done with regression testing so that is not the right thing to do

So we are going to revert the oldApp PR and then merge them before next deploy.

shubham1206agra · 2025-01-27T07:31:49Z

@mountiny Can you merge this PR atleast? Since it does not break standalone App. You can merge HybridApp PR as per #55509 (comment)

Skalakid · 2025-01-27T09:18:20Z

@shubham1206agra, we need to merge this PR with the patch rename in OldDot. Without it, we will have problems installing node_modules in HybridApp builds.

Here I prepared another PR with the patch version change cc @mountiny. Let's merge it :D

mountiny · 2025-01-28T10:23:03Z

the mobile-expensify change was merged https://github.com/Expensify/Mobile-Expensify/pull/13387

OSBotify · 2025-01-28T10:33:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…eact-native-live-markdown-0.1.221 Bump react-native-live-markdown version to 0.1.221 (cherry picked from commit 00f5edd) (CP triggered by mountiny)

github-actions · 2025-01-28T11:39:09Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.90-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-01-29T06:24:29Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

Skalakid added 2 commits January 21, 2025 10:28

Bump react-native-live-markdown version to 0.1.221

eb9add5

Merge branch 'main' into @Skalakid/bump-react-native-live-markdown-0.…

fe4d735

…1.221

Skalakid marked this pull request as ready for review January 21, 2025 12:40

Skalakid requested a review from a team as a code owner January 21, 2025 12:40

melvin-bot bot requested a review from sobitneupane January 21, 2025 12:40

melvin-bot bot removed the request for review from a team January 21, 2025 12:41

mountiny assigned Skalakid Jan 21, 2025

This was referenced Jan 21, 2025

[HOLD for payment 2025-02-06] [HOLD for payment 2025-02-05] [$250] Chat - Bold markdown gets triplicated when used as a second markdown in an emoji. #55115

Open

[$500] Do not allow emojis to be formatted (ie italics) #14676

Open

289Adam289 mentioned this pull request Jan 22, 2025

[HOLD for payment 2025-02-04] [Search v2.5] [Autocomplete] Highlight autocomplete key and selected value #50949

Open

sobitneupane reviewed Jan 22, 2025

View reviewed changes

mountiny added the Ready To Build label Jan 22, 2025

This comment has been minimized.

Sign in to view

sobitneupane reviewed Jan 22, 2025

View reviewed changes

Merge branch 'main' into @Skalakid/bump-react-native-live-markdown-0.…

00a619f

…1.221

Skalakid force-pushed the @Skalakid/bump-react-native-live-markdown-0.1.221 branch 2 times, most recently from cacb2d7 to e1a7fb3 Compare January 23, 2025 08:46

Update module commit

a2b5f3a

Skalakid force-pushed the @Skalakid/bump-react-native-live-markdown-0.1.221 branch from e1a7fb3 to a2b5f3a Compare January 23, 2025 08:47

sobitneupane approved these changes Jan 23, 2025

View reviewed changes

melvin-bot bot requested a review from grgia January 23, 2025 10:34

Add context menu format command handling

588bb46

Merge branch 'main' into @Skalakid/bump-react-native-live-markdown-0.…

c42fce4

…1.221

Skalakid mentioned this pull request Jan 24, 2025

Bump react-native-live-markdown to 0.1.223 #55706

Open

50 tasks

Skalakid added 2 commits January 24, 2025 15:22

Merge branch 'main' into @Skalakid/bump-react-native-live-markdown-0.…

54cd1ab

…1.221

Merge branch 'main' into @Skalakid/bump-react-native-live-markdown-0.…

ff91db1

…1.221

Merge branch 'main' into @Skalakid/bump-react-native-live-markdown-0.…

ac5a13f

…1.221

mountiny approved these changes Jan 24, 2025

View reviewed changes

mountiny changed the title ~~Bump react-native-live-markdown version to 0.1.221~~ [HOLD] Bump react-native-live-markdown version to 0.1.221 Jan 24, 2025

shubham1206agra mentioned this pull request Jan 27, 2025

Add handling short mentions tags to ExpensiMark Expensify/expensify-common#824

Open

jjcoffee mentioned this pull request Jan 27, 2025

[$250] Pasting data in chat puts the cursor in the wrong position #40025

Open

mountiny changed the title ~~[HOLD] Bump react-native-live-markdown version to 0.1.221~~ Bump react-native-live-markdown version to 0.1.221 Jan 28, 2025

mountiny changed the title ~~Bump react-native-live-markdown version to 0.1.221~~ [CP Staging] Bump react-native-live-markdown version to 0.1.221 Jan 28, 2025

mountiny merged commit 00f5edd into Expensify:main Jan 28, 2025
21 checks passed

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Jan 28, 2025

github-actions bot mentioned this pull request Jan 28, 2025

Deploy Checklist: New Expensify 2025-01-28 #55824

Closed

82 tasks

Skalakid mentioned this pull request Jan 28, 2025

[CP Staging] [No QA] Update Podfile after bumping the live-markdown to 0.1.221 #55853

Merged

50 tasks

lanitochka17 mentioned this pull request Jan 28, 2025

[$250] IOS - Chat - Emojis are cut off after applying bold formatting #55896

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Bump react-native-live-markdown version to 0.1.221 #55509

[CP Staging] Bump react-native-live-markdown version to 0.1.221 #55509

Skalakid commented Jan 21, 2025 •

edited

Loading

melvin-bot bot commented Jan 21, 2025

mountiny commented Jan 21, 2025

sobitneupane left a comment •

edited

Loading

github-actions bot commented Jan 22, 2025

This comment has been minimized.

github-actions bot commented Jan 22, 2025

mountiny commented Jan 22, 2025

github-actions bot commented Jan 22, 2025

sobitneupane left a comment

sobitneupane commented Jan 22, 2025

Skalakid commented Jan 23, 2025 •

edited

Loading

sobitneupane commented Jan 23, 2025 •

edited

Loading

sobitneupane left a comment

shubham1206agra commented Jan 23, 2025

Kicu commented Jan 24, 2025

Skalakid commented Jan 24, 2025

Skalakid commented Jan 24, 2025

mountiny commented Jan 24, 2025

mountiny commented Jan 24, 2025

shubham1206agra commented Jan 27, 2025

Skalakid commented Jan 27, 2025 •

edited

Loading

mountiny commented Jan 28, 2025

OSBotify commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 29, 2025

[CP Staging] Bump react-native-live-markdown version to 0.1.221 #55509

[CP Staging] Bump react-native-live-markdown version to 0.1.221 #55509

Conversation

Skalakid commented Jan 21, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Emoji splitting

With quote markdown, url text on tapping enter key not moved to next line

Compose box- Selected text isn't applied format

Context menu format command

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 21, 2025

mountiny commented Jan 21, 2025

sobitneupane left a comment • edited Loading

Choose a reason for hiding this comment

Screenshots/Videos

github-actions bot commented Jan 22, 2025

This comment has been minimized.

github-actions bot commented Jan 22, 2025

mountiny commented Jan 22, 2025

github-actions bot commented Jan 22, 2025

sobitneupane left a comment

Choose a reason for hiding this comment

sobitneupane commented Jan 22, 2025

Skalakid commented Jan 23, 2025 • edited Loading

sobitneupane commented Jan 23, 2025 • edited Loading

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

shubham1206agra commented Jan 23, 2025

Kicu commented Jan 24, 2025

Skalakid commented Jan 24, 2025

Skalakid commented Jan 24, 2025

mountiny commented Jan 24, 2025

mountiny commented Jan 24, 2025

shubham1206agra commented Jan 27, 2025

Skalakid commented Jan 27, 2025 • edited Loading

mountiny commented Jan 28, 2025

OSBotify commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 29, 2025

Skalakid commented Jan 21, 2025 •

edited

Loading

sobitneupane left a comment •

edited

Loading

Skalakid commented Jan 23, 2025 •

edited

Loading

sobitneupane commented Jan 23, 2025 •

edited

Loading

Skalakid commented Jan 27, 2025 •

edited

Loading