Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show NEW marker over unread messages, while scroll back from viewing history #5534

Merged
merged 2 commits into from
Oct 5, 2021

Conversation

Santhosh-Sellavel
Copy link
Collaborator

@Santhosh-Sellavel Santhosh-Sellavel commented Sep 26, 2021

Details

Fixed Issues

$ #5021

Tests & QA Steps

  1. Open any user chat.
  2. Scroll and view old messages
  3. When new messages arrive a new messages badge will show

Fixed:
When clicking on the new messages badge, now will show NEW unread indicator above the unread messages.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Web_04.mov

Mobile Web

mWeb_03.mp4

Desktop

Web_04.mov

iOS

iOS_02.mp4

Android

Android_1.mov

@Santhosh-Sellavel Santhosh-Sellavel requested a review from a team as a code owner September 26, 2021 17:25
@MelvinBot MelvinBot requested review from puneetlath and removed request for a team September 26, 2021 17:25
Copy link
Contributor

@puneetlath puneetlath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing. Then I think we're good to go!

src/pages/home/report/ReportActionsView.js Show resolved Hide resolved
@puneetlath puneetlath self-requested a review October 5, 2021 14:05
@puneetlath puneetlath merged commit 357af46 into Expensify:main Oct 5, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2021

🚀 Deployed to staging by @puneetlath in version: 1.1.5-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 7, 2021

🚀 Deployed to production by @chiragsalian in version: 1.1.6-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants