Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show NEW marker over unread messages, while scroll back from viewing history #5534

Merged
merged 2 commits into from
Oct 5, 2021
Merged

Show NEW marker over unread messages, while scroll back from viewing history #5534

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f16a56
Shows NEW indicator over unread messages, on interaction with new mar…
Santhosh-Sellavel Sep 26, 2021
bf12949
PR Requested Changes.
Santhosh-Sellavel Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/pages/home/report/ReportActionsView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,11 +399,15 @@ class ReportActionsView extends React.Component {
* @param {Boolean} [shouldResetLocalCount=false] Whether count should increment or reset
*/
updateLocalUnreadActionCount(shouldResetLocalCount = false) {
this.setState(prevState => ({
localUnreadActionCount: shouldResetLocalCount
this.setState((prevState) => {
const localUnreadActionCount = shouldResetLocalCount
puneetlath marked this conversation as resolved.
Show resolved Hide resolved
? this.props.report.unreadActionCount
: prevState.localUnreadActionCount + this.props.report.unreadActionCount,
}));
: prevState.localUnreadActionCount + this.props.report.unreadActionCount;
this.updateUnreadIndicatorPosition(localUnreadActionCount);
return {
Santhosh-Sellavel marked this conversation as resolved.
Show resolved Hide resolved
localUnreadActionCount,
};
});
}

/**
Expand Down