-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Create InlineSystemMessage component #9168
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5924182
Create style
Gonals 4b10ec0
Actually add the file
Gonals 87e5cc7
remove testing changes
Gonals 1a8f9f0
check message length
Gonals 37735dc
lint
Gonals 5981545
change export name
Gonals 78576a8
return null
Gonals File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import React from 'react'; | ||
import {View} from 'react-native'; | ||
import PropTypes from 'prop-types'; | ||
import styles from '../styles/styles'; | ||
import Text from './Text'; | ||
import * as Expensicons from './Icon/Expensicons'; | ||
import colors from '../styles/colors'; | ||
import Icon from './Icon'; | ||
|
||
const propTypes = { | ||
/** Error to display */ | ||
message: PropTypes.string.isRequired, | ||
}; | ||
|
||
const InlineSystemMessage = (props) => { | ||
if (props.message.length === 0) { | ||
return null; | ||
} | ||
return ( | ||
<View style={[styles.flexRow, styles.alignItemsCenter]}> | ||
<Icon src={Expensicons.Exclamation} fill={colors.red} /> | ||
<Text style={[styles.inlineSystemMessage]}>{props.message}</Text> | ||
</View> | ||
); | ||
}; | ||
|
||
InlineSystemMessage.propTypes = propTypes; | ||
InlineSystemMessage.displayName = 'InlineSystemMessage'; | ||
export default InlineSystemMessage; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should never reference
colors
directly in the UI – instead we should always reference themes. This is so that we can easily add darkmode (and potentially other themes?) later on.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a quick follow-up PR #9198
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, nice spot Rory. Thanks