-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Deploy help site to GitHub Pages #9689
Conversation
I branched off of marco-addNewHelpSite to create this PR. Once #9519 is merged and I merge main into this branch, the diff and number of commits will look a lot more reasonable. |
This is ready for review but I'd prefer to wait until I'm not OOO to merge/live-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, big fan of using dart-sass, and thanks for addressing all these changes that will enable us to use it for the help site @roryabraham!
Let's test this out! |
@roryabraham looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
This was passing tests. |
One thing I'm noticing is that HelpDot PRs have the potential to trigger unnecessary NewDot PRs. It won't happen now because the checklist is locked, but it's something we should clean up in a follow-up |
HelpDot deploy running here: https://github.com/Expensify/App/runs/7204996726?check_suite_focus=true |
Another thing I'm noticing is that there's no slack alert if this workflow fails. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
First follow-up: #9721 |
Ruby cache worked so the second deploy was super-duper quick 🎉 |
Second follow-up: #9722 |
🚀 Deployed to staging by @roryabraham in version: 1.1.81-0 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.1.82-5 🚀
|
Details
Deploys the Expensify Help site to GitHub Pages
Note: Links, styles, and scripts on the site will not work until we configure a custom domain. More details in this comment.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/216746
Tests
github.token
may fail. I didn't observe that in the test repo, but it may happen.