Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Deploy help site to GitHub Pages #9689

Merged
merged 3 commits into from
Jul 5, 2022
Merged

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Jul 3, 2022

Details

Deploys the Expensify Help site to GitHub Pages

Note: Links, styles, and scripts on the site will not work until we configure a custom domain. More details in this comment.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/216746

Tests

  1. Merge this PR
  2. The site should deploy on GitHub Pages.
  3. Note: action-gh-pages warns that the first deployment with the github.token may fail. I didn't observe that in the test repo, but it may happen.

@roryabraham roryabraham requested a review from a team as a code owner July 3, 2022 16:52
@roryabraham roryabraham self-assigned this Jul 3, 2022
@melvin-bot melvin-bot bot requested review from aldo-expensify and removed request for a team July 3, 2022 16:52
@roryabraham
Copy link
Contributor Author

I branched off of marco-addNewHelpSite to create this PR. Once #9519 is merged and I merge main into this branch, the diff and number of commits will look a lot more reasonable.

@roryabraham roryabraham requested a review from marcochavezf July 3, 2022 16:53
@roryabraham roryabraham changed the title [HOLD][No QA] Deploy help site to GitHub Pages [No QA] Deploy help site to GitHub Pages Jul 4, 2022
@roryabraham
Copy link
Contributor Author

This is ready for review but I'd prefer to wait until I'm not OOO to merge/live-test

Copy link
Contributor

@marcochavezf marcochavezf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, big fan of using dart-sass, and thanks for addressing all these changes that will enable us to use it for the help site @roryabraham!

@roryabraham
Copy link
Contributor Author

Let's test this out!

@roryabraham roryabraham merged commit 2761ca9 into main Jul 5, 2022
@roryabraham roryabraham deleted the Rory-DeployHelpSite branch July 5, 2022 22:15
@melvin-bot melvin-bot bot added the Emergency label Jul 5, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2022

@roryabraham looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@roryabraham
Copy link
Contributor Author

This was passing tests.

@roryabraham
Copy link
Contributor Author

One thing I'm noticing is that HelpDot PRs have the potential to trigger unnecessary NewDot PRs. It won't happen now because the checklist is locked, but it's something we should clean up in a follow-up

@roryabraham
Copy link
Contributor Author

@roryabraham
Copy link
Contributor Author

Weird, the community action didn't work with the ref we used in this PR:

image

I had only previously tested it with a tag, which goes against our GitHub Actions security guidelines for this repo.

@roryabraham
Copy link
Contributor Author

Another thing I'm noticing is that there's no slack alert if this workflow fails.

@OSBotify
Copy link
Contributor

OSBotify commented Jul 5, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor Author

First follow-up: #9721

@roryabraham
Copy link
Contributor Author

Ruby cache worked so the second deploy was super-duper quick 🎉

@roryabraham
Copy link
Contributor Author

Second follow-up: #9722

@OSBotify
Copy link
Contributor

OSBotify commented Jul 8, 2022

🚀 Deployed to staging by @roryabraham in version: 1.1.81-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.82-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants