Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Use commit hash from latest release tag #9722

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

roryabraham
Copy link
Contributor

Details

Main branch of https://github.com/peaceiris/actions-gh-pages does not have the release bundle under lib/index.js that's the main executable from it's action.yml file. It worked when I used the @v3 tag in a test repo: https://github.com/Andrew-Test-Org/Public-Test-Repo/pull/304/files#diff-485793c4ad92fb7d7366845a6b5a5e1d317cee350aa9f34ee627e0d7c1496527R25, but using a version tag goes against our GitHub Actions security guidelines in this repo. So this PR updates the commit hash to use the ref from the latest release tag, which has the lib/index.js file.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/216746

Tests

  1. Merge this PR
  2. The help site should deploy on GitHub Actions.

@roryabraham roryabraham requested a review from a team as a code owner July 5, 2022 22:39
@roryabraham roryabraham self-assigned this Jul 5, 2022
@melvin-bot melvin-bot bot requested review from yuwenmemon and removed request for a team July 5, 2022 22:39
@roryabraham roryabraham requested a review from marcochavezf July 5, 2022 22:40
@roryabraham roryabraham merged commit 35a41d9 into main Jul 5, 2022
@roryabraham roryabraham deleted the Rory-FixHelpDotDeploy branch July 5, 2022 22:46
@OSBotify
Copy link
Contributor

OSBotify commented Jul 5, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor Author

This worked but the deploy is still failing due to branch protections

@OSBotify
Copy link
Contributor

OSBotify commented Jul 8, 2022

🚀 Deployed to staging by @roryabraham in version: 1.1.81-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.82-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants