Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/disable scroll lock context menu #116

Merged
merged 2 commits into from
Jan 22, 2020

Conversation

tokland
Copy link
Contributor

@tokland tokland commented Jan 22, 2020

Required by EyeSeeTea/data-management-app#126

When the context menu is open, material-ui made some changes to the html/body to disable the overflow scrollbar. This moved some parts of the page to the right (ugly effect).

See mui/material-ui#17353

@SferaDev SferaDev changed the base branch from development to feature/allow-nodes-in-dialogs January 22, 2020 12:48
Copy link
Contributor

@SferaDev SferaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could not reproduce the bug but the change does not seem to introduce any visual effect on metadata-sync.

@adrianq adrianq changed the base branch from feature/allow-nodes-in-dialogs to development January 22, 2020 16:50
@adrianq adrianq merged commit 8eeaa1d into development Jan 22, 2020
@SferaDev SferaDev deleted the feature/disable-scroll-lock-context-menu branch January 27, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants