Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new objects table #126

Merged
merged 6 commits into from
Jan 22, 2020
Merged

Conversation

tokland
Copy link
Collaborator

@tokland tokland commented Jan 22, 2020

📌 References

🎨 Screenshots

image

image

image

@tokland tokland requested a review from adrianq January 22, 2020 13:46
@adrianq
Copy link
Member

adrianq commented Jan 22, 2020

Everything looks fine and works as expected. Two comments regarding the new table:

  • The contextual menu top-right corner should match the 3-dots
  • The original table used to be a bit more greyish for the font (check maintenance)
  • Check if possible to keep the row selected on right-button contextual open.

Original Table
image

New Table
image

I am aware they were already there for quick some time but if they are not too difficult can you please get them solved? I guess you will have to create a PR for d2-ui-comp so I am merging this...

@adrianq adrianq merged commit 2eddbdc into development Jan 22, 2020
@tokland tokland deleted the feature/use-new-objects-table-47 branch February 13, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new ObjecstTable for project list
2 participants