Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

Update GameVersion and modify ability checks order #278

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Update GameVersion and modify ability checks order #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions BasicRotations/PVPRotations/Ranged/BRD_Default.PVP.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
namespace DefaultRotations.Ranged;

[Rotation("Default PVP", CombatType.PvP, GameVersion = "7.05", Description = "Beta Rotation")]
[Rotation("Default PVP", CombatType.PvP, GameVersion = "7.1", Description = "Beta Rotation")]
[SourceCode(Path = "main/BasicRotations/PVPRotations/Ranged/BRD_Default.PvP.cs")]
[Api(4)]
public sealed class BRD_DefaultPvP : BardRotation
Expand Down Expand Up @@ -93,9 +93,9 @@ protected override bool AttackAbility(IAction nextGCD, out IAction? act)
act = null;
if (GuardCancel && Player.HasStatus(true, StatusID.Guard)) return false;

if (SilentNocturnePvP.CanUse(out act)) return true;
if (EncoreOfLightPvP.CanUse(out act, skipAoeCheck: true)) return true;

if (HarmonicArrowPvP_41964.CanUse(out act)) return true;
if (SilentNocturnePvP.CanUse(out act)) return true;

if (RepellingShotPvP.CanUse(out act)) return true;

Expand All @@ -117,6 +117,8 @@ protected override bool GeneralGCD(out IAction? act)
if (GuardCancel && Player.HasStatus(true, StatusID.Guard)) return false;
if (!Player.HasStatus(true, StatusID.Guard) && UseSprintPvP && !Player.HasStatus(true, StatusID.Sprint) && !InCombat && SprintPvP.CanUse(out act)) return true;

if (HarmonicArrowPvP_41964.CanUse(out act)) return true;

if (BlastArrowPvP.CanUse(out act)) return true;
if (ApexArrowPvP.CanUse(out act)) return true;

Expand Down