Skip to content

Commit

Permalink
Adjusted WillHaveXCharges
Browse files Browse the repository at this point in the history
- Leftover debug text for bard
- `WillHaveXCharges` Fix

From my testing `requiredTime` in `WillHaveXCharges` was always one recast time too much.
For example if we have Bard with 1 charge of bloodletter and `charges` is 2 then `requiredTime` was 15 when it probably should have been 0.
  • Loading branch information
Four-amer committed Sep 27, 2024
1 parent 3de4d1f commit 980b68d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion RotationSolver.Basic/Actions/ActionCooldownInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ public bool WillHaveXCharges(uint charges, float remain)
if (charges <= CurrentCharges)
return true;

float requiredTime = (charges - CurrentCharges) * RecastTimeOneChargeRaw;
float requiredTime = (charges - CurrentCharges - 1) * RecastTimeOneChargeRaw;
return RecastTimeRemainOneCharge <= remain - requiredTime;
}

Expand Down
1 change: 1 addition & 0 deletions RotationSolver.Basic/Rotations/Basic/BardRotation.cs
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ public override void DisplayStatus()
ImGui.Text("SongTimeRaw: " + SongTimeRaw.ToString());
ImGui.Text("SongTime: " + SongTime.ToString());
ImGui.Text("BloodletterMax: " + BloodletterMax.ToString());
ImGui.Text("Bloodlettercharges: " + BloodletterPvE.Cooldown.CurrentCharges.ToString());
}
#endregion

Expand Down

0 comments on commit 980b68d

Please sign in to comment.