Submodule update and fix TopPriorityHostile causing redtext #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated ECommons subproject commit to bf66e3d-dirty. Fixed ObjectHelper class in ObjectHelper.cs for null checks on TopPriorityHostile causing redtext events. Updated System.Drawing.Common to 8.0.10 in RotationSolver.Basic.csproj. Updated Microsoft.CodeAnalysis.CSharp to 4.11.0 in RotationSolver.SourceGenerators.csproj.
Removed `break` statements in `ActionCondition.cs` and directly returned `false` if conditions are not met. Changed `NextGCDActionChanged` and `NextActionChanged` events in `ActionUpdater.cs` from nullable `Action<uint>?` to non-nullable `Action<uint>` with default empty delegates to avoid null reference issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated ECommons subproject commit to bf66e3d-dirty.
Fixed ObjectHelper class in ObjectHelper.cs for null checks on TopPriorityHostile causing redtext events.
Updated System.Drawing.Common to 8.0.10 in RotationSolver.Basic.csproj.
Updated Microsoft.CodeAnalysis.CSharp to 4.11.0 in RotationSolver.SourceGenerators.csproj.
Removed
breakstatements inActionCondition.csand directly returnedfalseif conditions are not met. ChangedNextGCDActionChangedandNextActionChangedevents inActionUpdater.csfrom nullableAction<uint>?to non-nullableAction<uint>with default empty delegates to avoid null reference issues.