Add BioMove option, update logic, and enhance debug UI #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new configuration option `BioMove` to the `MCH_Default` and `MCH_HighEnd` classes, allowing Bioblaster use while moving. Updated logic to check `BioMove` setting before using Bioblaster, ensuring it can be used if `BioMove` is enabled or if the player is not moving. Updated subproject commit reference in `ECommons` to `a1df6434ddac33eab306b3f4f605f59f0d0a7279`. Enhanced `RotationConfigWindow` to display stack count of statuses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
BasicRotationsandRotationSolvermodules to enhance functionality and improve the user interface. The most important changes are summarized below:Enhancements to
BasicRotations:BioMovetoMCH_DefaultandMCH_HighEndclasses to allow the use ofBioblasterwhile moving. (BasicRotations/Ranged/MCH_Default.cs, [1];BasicRotations/Ranged/MCH_HighEnd.cs, [2]GeneralGCDmethod in bothMCH_DefaultandMCH_HighEndclasses to respect the newBioMoveconfiguration option. (BasicRotations/Ranged/MCH_Default.cs, [1];BasicRotations/Ranged/MCH_HighEnd.cs, [2]Improvements to
RotationSolverUI:DrawStatusmethod inRotationConfigWindow.csto display the stack count of status effects, converting a stack value of 255 to "N/A" for better readability. (RotationSolver/UI/RotationConfigWindow.cs, RotationSolver/UI/RotationConfigWindow.csL2817-R2819)Submodule Update:
ECommonssubmodule to a new commit. (ECommons, ECommonsL1-R1)