Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BioMove option, update logic, and enhance debug UI #614

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Add BioMove option, update logic, and enhance debug UI #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion BasicRotations/Ranged/MCH_Default.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ public sealed class MCH_Default : MachinistRotation

[RotationConfig(CombatType.PvE, Name = "Prevent the use of defense abilties during hypercharge burst")]
private bool BurstDefense { get; set; } = false;

[RotationConfig(CombatType.PvE, Name = "Use Bioblaster while moving")]
private bool BioMove { get; set; } = true;
#endregion

#region Countdown logic
Expand Down Expand Up @@ -131,7 +134,7 @@ protected override bool GeneralGCD(out IAction? act)
if (HeatBlastPvE.CanUse(out act)) return true;

// drill's aoe version
if (BioblasterPvE.CanUse(out act, usedUp: true)) return true;
if ((BioMove || (!IsMoving && !BioMove)) && BioblasterPvE.CanUse(out act, usedUp: true)) return true;

// single target --- need to update this strange condition writing!!!
if (!SpreadShotPvE.CanUse(out _))
Expand Down
5 changes: 4 additions & 1 deletion BasicRotations/Ranged/MCH_HighEnd.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ public sealed class MCH_HighEnd : MachinistRotation

[RotationConfig(CombatType.PvE, Name = "Use burst medicine midfight when Air Anchor, Barrel Stabilizer, and Wildfire are about to come off cooldown")]
private bool MidfightBurstMeds { get; set; } = false;

[RotationConfig(CombatType.PvE, Name = "Use Bioblaster while moving")]
private bool BioMove { get; set; } = true;
#endregion

private const float HYPERCHARGE_DURATION = 8f;
Expand Down Expand Up @@ -147,7 +150,7 @@ protected override bool GeneralGCD(out IAction? act)
if (HeatBlastPvE.CanUse(out act)) return true;

// drill's aoe version
if (BioblasterPvE.CanUse(out act, usedUp: true)) return true;
if ((BioMove || (!IsMoving && !BioMove)) && BioblasterPvE.CanUse(out act, usedUp: true)) return true;

// single target --- need to update this strange condition writing!!!
if (!SpreadShotPvE.CanUse(out _))
Expand Down
2 changes: 1 addition & 1 deletion ECommons
Open in desktop
Submodule ECommons updated 3 files
+2 −0 ECommons/ExcelServices/BaseParamEnum.cs
+8 −2 ECommons/GameHelpers/Player.cs
+42 −4 ECommons/GenericHelpers.cs
4 changes: 3 additions & 1 deletion RotationSolver/UI/RotationConfigWindow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2814,7 +2814,9 @@ private static unsafe void DrawStatus()
foreach (var status in Player.Object.StatusList)
{
var source = status.SourceId == Player.Object.GameObjectId ? "You" : Svc.Objects.SearchById(status.SourceId) == null ? "None" : "Others";
ImGui.Text($"{status.GameData.Value.Name}: {status.StatusId} From: {source}");
byte stacks = Player.Object.StatusStack(true, (StatusID)status.StatusId);
string stackDisplay = stacks == byte.MaxValue ? "N/A" : stacks.ToString(); // Convert 255 to "N/A"
ImGui.Text($"{status.GameData.Value.Name}: {status.StatusId} From: {source} Stacks: {stackDisplay}");
}
}

Expand Down