Adding firebase storage #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>
Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>
Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>
Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>
Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>
Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>
Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>
Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>
Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>
Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>
Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>
Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>
…ng-firebase-storage
Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>
Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>
Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>
Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>
|
@tjmonsi The |
firebase-messaging.html
Outdated
| @@ -39,7 +39,7 @@ | |||
|
|
|||
| ```html | |||
| <firebase-messaging token="{{token}}"></firebase-messaging> | |||
| <firebase-document path="/users/[[user.uid]]/token" data="[[token]]"></firebase-document> | |||
There was a problem hiding this comment.
Please rebase. See 4640bea.
|
@mbleigh is this ok to be merged? |
…orage Various fixes
This was referenced Jun 23, 2017
Closed
|
Trying to get to it ASAP. I'd like to take one more look, it's just been crazy. Sorry for the delay. |
…ts with same name
…g to a path, doing ref.child(path).put(...) it pointing twice too deep in the storage tree.
Fix upload path
|
@mbleigh - any chance this will get merged? |
|
@mbleigh any progress on this one? |
|
any news on this? |
|
waiting for this feature way over 1 year now... same question here |
e111077
approved these changes
Sep 5, 2017
|
@e111077 alright! Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mbleigh Here's the new PR as requested.
I changed the toString to toGsString because it doesn't show in the api documentation. I think because toString is part of an object's original set of methods so it skips that.