Adding firebase storage capability (w/ multiple files) #69

tjmonsi · 2016-07-08T14:59:53Z

Following the patterns from <firebase-document>, I would like to ask for review for that addition of two components: Polymer.FirebaseStorageBehavior and <firebase-storage>

firebase-storage allows the uploading of a single or multiple files from a File object or an Array of File objects (FileList) fed to the file attribute. You can then call the .upload() method to upload the files manually or just add auto-upload attribute to automatically upload the files.

All files and their statuses are returned via the uploaded-files property, where each element inside will be updated via events inside.

Other methods:
destroy() to delete the file / folder in the path.
resume(i), pause(i), cancel(i): the methods found in the upload tasks. The i parameter is for accessing the file element in the array returned from uploaded-files

Example usage as follows:

<firebase-storage
        id="fs"
        path="/users/{{user.uid}}/files"
        files="[[files]]"
        uploaded-files="{{uploadedFiles}}"
        on-error="catchError"
        auto-upload>
</firebase-storage>

You can play with the demo here: https://practice-play-for-polymer-tjmonsi1.c9users.io/

This is an offshoot of the PR #30 and hopefully a fix for #10.

Some bugs:
cancel, resume, and pause sometimes doesn't respond even when wrapped around a promise. Will try to figure out why.

Would like to get some feedback

tjmonsi · 2016-08-19T16:02:18Z

@mbleigh Hi, would like to know any updates on this :)

mbleigh · 2016-08-19T16:59:06Z

Plan to take a closer look next week, thanks

On Fri, Aug 19, 2016, 9:02 AM Toni-Jan Keith Monserrat <
[email protected]> wrote:

@mbleigh https://github.com/mbleigh Hi, would like to know any updates
on this :)

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#69 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAD_u_Nns0SG6CdfbesS10DW6aMFNIoks5qhdOKgaJpZM4JIHKx
.

sbeleidy · 2016-09-17T15:36:58Z

We're trying to use this and we can upload files fine. We're having trouble understanding how to access files from firebase storage however. One way we imagine this working would be something like:

<firebase-storage
      id="fs"
      app-name="myapp"
      path="/path/to/image.png"
      files="[[files]]"
      on-error="catchError">
      </firebase-storage>

<img src="[[files]]" alt="my file">

I see that there's a function for getDownloadUrl() but not sure how this should be used.

Or is the intended use to getDownloadUrl() on upload and store that in the database instead?

Could you please clarify how this should be used for downloading ?

tjmonsi · 2016-09-17T17:11:01Z

Hi Saad,

Unfortunately, the current implementation does not behave the same firebase
document where it has a one to one correspondence with the path. It is only
used as of now as an uploader (that's why it uses getdownloadurl) But given
your idea, i think this can be done... Lemme check the code again and then
give a documentation.

On Sat, 17 Sep 2016 23:37 Saad Elbeleidy, [email protected] wrote:

We're trying to use this and we can upload files fine. We're having
trouble understanding how to access files from firebase storage however.
One way we imagine this working would be something like:

I see that there's a function for getDownloadUrl() but not sure how this
should be used.

Or is the intended use to getDownloadUrl() on upload and store that in the
database instead?

Could you please clarify how this should be used for downloading ?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#69 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AChe1sVp2fBvvyXTt37bjT_5MWTpGa4cks5qrAkcgaJpZM4JIHKx
.

tjmonsi · 2016-09-22T11:39:32Z

@mbleigh would like to follow this up. I like the idea of @sbeleidy though but would like to know what would be the thrust of the polymerfire team on this

googlebot · 2016-10-17T11:33:53Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

tjmonsi · 2016-10-17T11:36:24Z

@googlebot The added parts are just from the messaging branch from the polymerfire.

tjmonsi · 2016-10-25T14:51:31Z

@mbleigh hi. would like to know if i should rewrite this or is this still a part of the plan of polymerfire

locomuco · 2016-11-07T12:05:44Z

demo/firebase-messaging.html

+      p {
+        margin: 32px 32px 0;
+      }
+>>>>>>> upstream/master


the latest commit brought in some merge conflicts that need to be resolved

nice catch there. thanks

jorgecasar · 2017-02-09T19:44:03Z

@tjmonsi, can you fix the commits? I would like to get this to update it with more features.

JosefJezek · 2017-02-12T10:33:04Z

@mbleigh @cdata @tjmonsi Please resolve this PR.

tjmonsi · 2017-02-12T11:48:36Z

Will get back on this this tuesday. Just had a surgery. Sorry :(

…

On Sun, 12 Feb 2017 18:33 Josef Jezek, ***@***.***> wrote: @mbleigh <https://github.com/mbleigh> @cdata <https://github.com/cdata> @tjmonsi <https://github.com/tjmonsi> Please resolve this PR. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#69 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AChe1peKeZPzmCjs_1PBqlHmmp2G3LHYks5rbt_hgaJpZM4JIHKx> .

googlebot · 2017-02-12T11:48:40Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

tjmonsi · 2017-02-14T02:38:57Z

@jorgecasar It is said that the branch has no conflicts with the base branch, so I am just waiting for them to merge. I don't know what @mbleigh 's plans on having a firebase-storage but then again... I am happy to help now that I am back (after my surgery). If there's anything I need to change, please help me and point it out so I can fix it easily. Thanks 😄

locomuco · 2017-02-14T07:25:12Z

@tjmonsi there are still some conflicts in the PR, have a quick look at the changed files, seems there went something wrong resolving merge conflicts

I hope that PR makes it into mainline after all 👍

tjmonsi · 2017-02-14T07:44:58Z

Hmmm... what I'm going to do is to check if I can still do a rebase. If not, I'll just open another PR and close this one. Thanks @locomuco

tjmonsi · 2017-02-14T07:58:28Z

@locomuco how about now? It's still saying that this branch has no conflicts with the base branch. I updated the dependencies though

locomuco · 2017-02-14T08:10:44Z

demo/firebase-messaging.html

@@ -45,10 +45,13 @@
      main {
        padding: 32px;
      }
+<<<<<<< HEAD


there are still wrongly resolved conflicts

jorgecasar · 2017-02-14T08:14:26Z

@tjmonsi there are 2 thins to solve:

Issue with merge in some files firebase-messaging. Take a look file changes (https://github.com/firebase/polymerfire/pull/69/files).
It is not allowed to include commits from others.

tjmonsi · 2017-02-14T09:06:20Z

I guess I'll just have to create another PR then. I think the one i did before made the conflict

Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>

googlebot · 2017-02-14T09:13:35Z

CLAs look good, thanks!

googlebot · 2017-05-25T17:39:25Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

tjmonsi · 2017-05-25T17:39:53Z

@FluorescentHallucinogen I think you need to sign the CLA now for this to work :)

tjmonsi · 2017-05-25T17:41:19Z

I've also found that toString method for some reason is not listed on API Reference page. If I rename it to e.g. toString2, all is ok…

@FluorescentHallucinogen what do you mean?

FluorescentHallucinogen · 2017-05-25T18:05:06Z

@googlebot All is ok.

FluorescentHallucinogen · 2017-05-25T18:28:28Z

@tjmonsi

@FluorescentHallucinogen what do you mean?

Run polymer serve and check "Methods" section on http://127.0.0.1:****/components/polymerfire/#firebase-storage-ref page.

FluorescentHallucinogen · 2017-05-26T08:21:48Z

bower.json

@@ -24,8 +24,11 @@
  },
  "devDependencies": {
    "iron-component-page": "PolymerElements/iron-component-page#1 - 2",
+    "note-app-elements": "polymerlabs/note-app-elements#1 - 2",


Please remove "note-app-elements" deps as demo was removed.

FluorescentHallucinogen · 2017-05-26T08:22:19Z

bower.json

@@ -36,8 +39,11 @@
      },
      "devDependencies": {
        "iron-component-page": "PolymerElements/iron-component-page#^1.0",
+        "note-app-elements": "polymerlabs/note-app-elements",


Please remove it too.

FluorescentHallucinogen · 2017-05-26T08:25:10Z

firebase-storage-multiupload.html

+    * There are two ways to do this. You can encapsulate `firebase-storage-upload-task` in another
+    * element to have a local scope of the upload task's state:
+    * ```
+    *   //file-uploader


Please remove it, because looks like it breaks the markup.

FluorescentHallucinogen · 2017-05-26T08:25:22Z

firebase-storage-multiupload.html

+    *     </template>
+    *
+    *
+    *   // file-task


Please remove it too.

FluorescentHallucinogen · 2017-05-26T08:36:02Z

demo/firebase-storage-multiupload-demo.html

+
+
+
+          path from snapshot: {{item.snapshot.ref.fullPath}} <br/>


What about changing two-way data flow to one-way (double curly brackets — {{ }} to double square brackets — [[ ]]) around the all code where it is needed?

i'll do that.

Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>

googlebot · 2017-05-26T10:31:31Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

tjmonsi · 2017-05-26T10:33:14Z

@FluorescentHallucinogen I think CLA is not yet ok. Can you try again?

FluorescentHallucinogen · 2017-05-26T10:46:49Z

@googlebot I signed it!

FluorescentHallucinogen · 2017-05-26T10:55:55Z

@tjmonsi Looks like a @googlebot bug. I signed Google Individual CLA Mar 12, 2016 06:22 PST. The ID of my CLA is 108694818465100465718. What should I do?

tjmonsi · 2017-05-26T13:37:00Z

Should I try squashing the commit? guys?

FluorescentHallucinogen · 2017-05-26T13:54:38Z

@mbleigh PTAL.

tjmonsi · 2017-05-26T23:50:35Z

@FluorescentHallucinogen can you try saying you confirm to submit to @googlebot ? It asks that "We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request."

mbleigh · 2017-05-26T23:52:56Z

I think the CLA is fine -- it's in a "terminal state" but it says I can merge on my discretion. I'm going to try to take another look through the code ASAP (probably not until next week) to see if we've got everything we need.

tjmonsi · 2017-05-27T01:27:24Z

@mbleigh thanks. :)

JosefJezek · 2017-05-30T16:51:08Z

@mbleigh I am waiting for firebase-storage. Thank you.

FluorescentHallucinogen · 2017-05-31T11:38:10Z

@tjmonsi What about the problem with toString method that I reported earlier? Why toString method is not listed in "Methods" section on the API Reference page?

tjmonsi · 2017-05-31T12:15:59Z

https://firebase.google.com/docs/reference/js/firebase.storage.Reference#toString

…

On Wed, 31 May 2017 19:38 Alexey Rodionov, ***@***.***> wrote: @tjmonsi <https://github.com/tjmonsi> What about the problem with toString method that I reported earlier? Why toString <https://github.com/firebase/polymerfire/pull/69/files#diff-275a8c1aff9eeaf594afd11a42e9eedeR190> method is not listed in "Methods" section on the API Reference page <https://www.webcomponents.org/preview/tjmonsi/polymerfire/58462a6a9f52b06072c1ee684adfe2bc2b07e793/elements/firebase-storage-ref#methods> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#69 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AChe1gmJNKGLN0dAEHQqf96VbAFY7yqhks5r_VEjgaJpZM4JIHKx> .

FluorescentHallucinogen · 2017-05-31T13:18:52Z

@tjmonsi My question was "Why toString method is not listed in Methods section?". Why, e.g. putString and updateMetadata are listed, but toString is not?

FluorescentHallucinogen · 2017-05-31T13:30:45Z

@tjmonsi

tjmonsi · 2017-05-31T14:26:18Z

I haven't updated the Readme. Sorry about that

…

On Wed, 31 May 2017 21:30 Alexey Rodionov, ***@***.***> wrote: @tjmonsi <https://github.com/tjmonsi> [image: screenshot] <https://cloud.githubusercontent.com/assets/7892779/26634169/6e9a9d5c-461e-11e7-9c80-34212fde4fda.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#69 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AChe1ijVQUudaQT2RS07EnNF81iA9T_7ks5r_WuGgaJpZM4JIHKx> .

mbleigh · 2017-06-01T00:18:44Z

Whoops! I just accidentally pushed this sucker to master based on a bad local git state. Hold on to your branch, please, I'm going to try to untangle this mess.

mbleigh · 2017-06-01T00:22:18Z

@tjmonsi can you please open a new pull request from the same branch? I've hard reset master back to where it was before.

tjmonsi · 2017-06-01T00:31:14Z

Will do

…

On Thu, Jun 1, 2017 at 8:22 AM Michael Bleigh ***@***.***> wrote: @tjmonsi <https://github.com/tjmonsi> can you please open a new pull request from the same branch? I've hard reset master back to where it was before. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#69 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AChe1gP4VbpzVDfvAUx6ESQ-ZRqSNtKJks5r_gQ8gaJpZM4JIHKx> .

eeerrrttty · 2017-06-21T01:53:02Z

Please, im a noob, so, you pro guys... Can you make an EASY example of an image upload process? Including html, scripts in polymer and the API structure?

Can this be used with polymer 2?

Can i use the firebase/polymerfire api or should i use the tjmonsi fork???

locomuco · 2017-06-21T05:39:52Z

@eeerrrttty have a look here at this PR, the PR was moved

tjmonsi added 7 commits July 7, 2016 20:12

Added firebase-storage-behavior.html

3850ca3

Added firebase-storage and fixed firebase-storage-behavior

72c1d5c

Fixed a bug in firebase-storage and added it in polymerfire

24fc775

Fixed some bugs on the multiple uploads and added a demo

1074832

Fixed delete

8d30ef5

Current stable version done

edbab3a

Added fix on firebase-storage-behavior.html

d059a33

stemuk mentioned this pull request Aug 1, 2016

Add polymerfire storage elements #92

Open

locomuco reviewed Nov 7, 2016

View reviewed changes

locomuco reviewed Feb 14, 2017

View reviewed changes

demo/firebase-messaging.html Outdated

@@ -45,10 +45,13 @@

main {

padding: 32px;

}

<<<<<<< HEAD

Copy link

locomuco Feb 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are still wrongly resolved conflicts

Updated firebase-storage-behavior and firebase-storage

d2b3b6a

Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>

Merge branch 'master' into adding-firebase-storage

b873894

FluorescentHallucinogen reviewed May 26, 2017

View reviewed changes

added fixes

58462a6

Signed-off-by: Toni-Jan Keith Monserrat <[email protected]>

mbleigh merged commit 58462a6 into FirebaseExtended:master Jun 1, 2017

tjmonsi mentioned this pull request Jun 1, 2017

Adding firebase storage #226

Merged

Adding firebase storage capability (w/ multiple files) #69

Adding firebase storage capability (w/ multiple files) #69

Conversation

tjmonsi commented Jul 8, 2016

tjmonsi commented Aug 19, 2016

mbleigh commented Aug 19, 2016

sbeleidy commented Sep 17, 2016 • edited Loading

tjmonsi commented Sep 17, 2016

tjmonsi commented Sep 22, 2016

googlebot commented Oct 17, 2016

tjmonsi commented Oct 17, 2016

tjmonsi commented Oct 25, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jorgecasar commented Feb 9, 2017

JosefJezek commented Feb 12, 2017

tjmonsi commented Feb 12, 2017 via email

googlebot commented Feb 12, 2017

tjmonsi commented Feb 14, 2017

locomuco commented Feb 14, 2017

tjmonsi commented Feb 14, 2017

tjmonsi commented Feb 14, 2017

Choose a reason for hiding this comment

jorgecasar commented Feb 14, 2017

tjmonsi commented Feb 14, 2017

googlebot commented Feb 14, 2017

googlebot commented May 25, 2017

tjmonsi commented May 25, 2017

tjmonsi commented May 25, 2017

FluorescentHallucinogen commented May 25, 2017

FluorescentHallucinogen commented May 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

googlebot commented May 26, 2017

tjmonsi commented May 26, 2017

FluorescentHallucinogen commented May 26, 2017

FluorescentHallucinogen commented May 26, 2017

tjmonsi commented May 26, 2017

FluorescentHallucinogen commented May 26, 2017

tjmonsi commented May 26, 2017

mbleigh commented May 26, 2017 • edited Loading

tjmonsi commented May 27, 2017

JosefJezek commented May 30, 2017

FluorescentHallucinogen commented May 31, 2017

tjmonsi commented May 31, 2017 via email

FluorescentHallucinogen commented May 31, 2017

FluorescentHallucinogen commented May 31, 2017

tjmonsi commented May 31, 2017 via email

mbleigh commented Jun 1, 2017

mbleigh commented Jun 1, 2017

tjmonsi commented Jun 1, 2017 via email

eeerrrttty commented Jun 21, 2017

locomuco commented Jun 21, 2017

sbeleidy commented Sep 17, 2016 •

edited

Loading

mbleigh commented May 26, 2017 •

edited

Loading