GameKit implementation of "AddUnique" does not match documented behavior

[petergiuntoli]

I wasn't sure if this was brought in from somewhere else or is home grown but AddUnique is documented as returning true if adding an element but it actually returns true if the element already exists.

FishNet/Assets/FishNet/Plugins/GameKit/Dependencies/Utilities/Arrays.cs

Lines 18 to 29 in d780e80

	/// <summary>
	/// Adds an entry to a list if it does not exist already.
	/// </summary>
	/// <returns>True if being added.</returns>
	public static bool AddUnique<T>(this List<T> list, object value)
	{
	bool contains = list.Contains((T)value);
	if (!contains)
	list.Add((T)value);
	return contains;
	}

I notice that this is causing unintended behavior inside "CanvasTracker"

FishNet/Assets/FishNet/Plugins/GameKit/Dependencies/Utilities/Types/Canvases/CanvasTracker.cs

Lines 93 to 105 in d780e80

	/// <summary>
	/// Adds a canvas to OpenCanvases if not already added.
	/// </summary>
	/// <param name="addToBlocking">True to also add as an input blocking canvas.</param>
	/// <returns>True if the canvas was added, false if already added.</returns>
	public static bool AddOpenCanvas(object canvas, bool addToBlocking)
	{
	bool added = _openCanvases.AddUnique(canvas);
	if (added && addToBlocking)
	_inputBlockingCanvases.Add(canvas);
	return added;
	}

Additionally I think the function signature could make the "object" a type T instead of boxing internally but that's a separate issue.

public static bool AddUnique<T>(this List<T> list, T value)

I ended up noticing this because my game has it's own implementation of AddUnique but vscode chooses to autocomplete the "gamekit" version first which has the opposite return value behavior.

[FirstGearGames]

You are right on both. Fixed and improved in v3.11.14 and 4.0.7.