Update DistanceCondition.cs #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DistanceCondition flickering fix.
|
Thank you for this find. Your fix does work but I do not believe the calculated result is the intended result. Code: float maxDistanceHide = _maximumDistance * (1f + _hideDistancePercent);
_sqrHideMaximumDistance = (maxDistanceHide * maxDistanceHide); |
|
Going to accept the PR for find credit. ty again. |
FirstGearGames
pushed a commit
that referenced
this pull request
Jan 12, 2024
- Added TransportManager.Get/SetMTUReserve(int) to allow reserving bytes in buffers, such as use with IntermediateLayer to insert encryption data. Reserving bytes does not consume more bandwidth if bytes are not filled. - Improved TransportManager.GetMTU methods to consider reserve. - Improved exposed TimeManager.PingInterval. - Fixed Fish-Networking menu item order. - Improved created replicates which arrive after the run tick are now run in replays instead of twice. - Changed ReplicateState.UserCreated renamed to CurrentCreated for clarity. - Changed ReplicateState.Predicted renamed to CurrentPredicted for clarity. - Changed ReplicateState.ReplayedPredicted/UserCreated renamed to Replayed. - Added ReplicateState.Future to indicate future prediction of objects. - Changed SceneLoad/UnloadData PreferredScene is now a structure. - Added SceneLoad/UnloadData PreferredScene can now specify different scenes for client and server. - Fixed Prediction v2 reconcile desyncs for NonAuthoritative. - Fixed Prediction v2 reconcile desyncs for Authoritative. - Improved RigidbodyPauser to be simplified and more flexible for edge-case setups. - Fixed Prediction v2 garbage allocation from physics. - Fixed Prediction v2 excessive replays of remote objects when local client was not moving. - Removed NetworkManager.StaticLogXYZ methods. - Added NetworkManagerExtensions.Log/Warnig/Error. - Added Log/Warning/Error extensions for NetworkManager references; null references may be used. - Improved NetworkManager logging methods now use Unity debug when NetworkManager does not exist in any scene. - Improved ServerManager.ShareIds made public. - Improved BufferLast always uses reliable channel for new observers now. - Fixed a SyncType not being set dirty by server within OnStartServer due to no observers count, resulting in predicted spawners not getting the new value update. - Added Prediction v2 teleport option for graphical object. - Improved List.AddUnique now returns if added, as well value no longer boxes. (#579)(#580) - Fixed preferred scene not being applied to global scenes for late joiners (#585) - Fixed inversed transform offsets in GetTransformOffsets and SetTransformOffsets. (#578) - Fixed DistanceCondition causing flickering due to incorrect hide distance calculation. (#576)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DistanceCondition flickering fix. Hide distance calculation was incorrect.