Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlowETL using default secret_key #3244

Closed
greenape opened this issue Nov 10, 2020 · 1 comment · Fixed by #3245 or #3283
Closed

FlowETL using default secret_key #3244

greenape opened this issue Nov 10, 2020 · 1 comment · Fixed by #3245 or #3283
Labels
bug Something isn't working FlowETL security

Comments

@greenape
Copy link
Member

This is insecure. It should be using either an explicitly provided one, or randomly generating one at runtime.
@greenape greenape added bug Something isn't working security FlowETL labels Nov 10, 2020
greenape added a commit that referenced this issue Nov 10, 2020
@greenape
Fix using default secret key where AIRFLOW__WEBSERVER__SECRET_KEY is …
9831145 
…not set #3244
greenape added a commit that referenced this issue Nov 10, 2020
@greenape
Fix using default secret key where AIRFLOW__WEBSERVER__SECRET_KEY is …
db1b087 
…not set #3244
@greenape greenape mentioned this issue Nov 10, 2020
Merged
8 tasks
greenape added a commit that referenced this issue Nov 10, 2020
@greenape
Fix using default secret key where AIRFLOW__WEBSERVER__SECRET_KEY is …
2e0d6f3 
…not set #3244
@jc-harrison
Copy link
Member

I'm finding that entrypoint.sh still doesn't set AIRFLOW__WEBSERVER__SECRET_KEY if it's not set explicitly. I haven't worked out why yet.

@jc-harrison jc-harrison reopened this Nov 13, 2020
greenape added a commit that referenced this issue Nov 16, 2020
@greenape
Fix #3244
4786b9b
@greenape greenape mentioned this issue Nov 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working FlowETL security
Projects
None yet
Milestone
No milestone
2 participants
@greenape @jc-harrison