Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix randomly generated secret key not being used #3283

Merged
merged 4 commits into from
Nov 17, 2020
Merged

Conversation

greenape
Copy link
Member

Closes #3244

@greenape greenape added bug Something isn't working FlowETL labels Nov 16, 2020
@cypress
Copy link

cypress bot commented Nov 16, 2020



Test summary

43 0 0 0


Run details

Project FlowAuth
Status Passed
Commit cf55092
Started Nov 17, 2020 9:56 AM
Ended Nov 17, 2020 9:58 AM
Duration 02:39 💡
OS Linux Debian - 8.11
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #3283 (cf55092) into master (fe75bc2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3283   +/-   ##
=======================================
  Coverage   93.13%   93.13%           
=======================================
  Files         251      251           
  Lines       10131    10131           
  Branches      867      867           
=======================================
  Hits         9436     9436           
  Misses        563      563           
  Partials      132      132           
Flag Coverage Δ
autoflow_unit_tests 92.99% <ø> (ø)
flowapi_unit_tests 72.84% <ø> (ø)
flowauth_unit_tests 78.39% <ø> (ø)
flowclient_unit_tests 74.72% <ø> (ø)
flowetl_unit_tests 95.38% <ø> (ø)
flowkit_jwt_generator_unit_tests 95.10% <ø> (ø)
flowmachine_unit_tests 90.79% <ø> (ø)
integration_tests 66.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe75bc2...cf55092. Read the comment docs.

@greenape greenape merged commit 55a5ab9 into master Nov 17, 2020
@greenape greenape deleted the add-missing-export branch November 17, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FlowETL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FlowETL using default secret_key
1 participant