Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty tables argument raises MissingDateError even if data for the given dates is present #436

Closed
maxalbert opened this issue Feb 28, 2019 · 0 comments · Fixed by #4367
Closed

Empty tables argument raises MissingDateError even if data for the given dates is present #436

maxalbert opened this issue Feb 28, 2019 · 0 comments · Fixed by #4367
Labels
bug Something isn't working FlowMachine Issues related to FlowMachine

Comments

@maxalbert
Copy link
Contributor

Describe the bug
Passing an empty tables argument (e.g. to EventTablesUnion) raises a MissingDateError even if data for the given dates are present.

Product
Flowmachine

Version
Current master

To Reproduce

>>> from flowmachine.features import EventsTablesUnion
>>> EventsTablesUnion("2016-01-01", "2016-01-02", columns=["msisdn"], tables=[])

MissingDateError: No data for date: 2016-01-01 - 2016-01-02

Expected behavior
A more meaningful error should be raised to indicate that the tables argument must not be empty.

A fix will be included in an upcoming PR, I just wanted to have an issue for this to have it tracked.
@maxalbert maxalbert added bug Something isn't working FlowMachine Issues related to FlowMachine labels Feb 28, 2019
@greenape greenape added the P-Now label Sep 23, 2021
greenape added a commit that referenced this issue Oct 4, 2021
@greenape
Fix misleading error with empty table list #436
be0afaf
@greenape greenape mentioned this issue Oct 5, 2021
Merged
8 tasks
greenape added a commit that referenced this issue Oct 20, 2021
@greenape
Fix misleading error with empty table list #436
5646835
greenape added a commit that referenced this issue Apr 29, 2022
@greenape
Fix misleading error with empty table list #436
0239833
greenape added a commit that referenced this issue Jun 13, 2022
@greenape
Fix misleading error with empty table list #436
b007ad5
greenape added a commit that referenced this issue Nov 7, 2022
@greenape
Fix misleading error with empty table list #436
053b0e7
greenape added a commit that referenced this issue Nov 7, 2022
@greenape
Fix misleading error with empty table list #436
5a1ac43
greenape added a commit that referenced this issue Nov 8, 2022
@greenape
Fix misleading error with empty table list #436
918d80c
greenape added a commit that referenced this issue Nov 11, 2022
@greenape
Fix misleading error with empty table list #436
af3e89c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working FlowMachine Issues related to FlowMachine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix misleading error with empty table list Flowminder/FlowKit
2 participants
@greenape @maxalbert