Fix misleading error with empty table list #4367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenape
added
bug
greenape
force-pushed
the
fix-incorrect-error-with-no-tables
branch
from
be0afaf to
5646835
Compare
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
greenape
force-pushed
the
fix-incorrect-error-with-no-tables
branch
from
9517a29 to
0239833
Compare
greenape
force-pushed
the
fix-incorrect-error-with-no-tables
branch
from
0239833 to
b007ad5
Compare
greenape
force-pushed
the
fix-incorrect-error-with-no-tables
branch
3 times, most recently
from
5a1ac43 to
918d80c
Compare
greenape
force-pushed
the
fix-incorrect-error-with-no-tables
branch
from
918d80c to
af3e89c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #436
I have:
Description
Fixes the misleading missing dates error raised when passing an empty list of tables to
EventsTablesUnion. Instead it will now raise aValueErrorstating that the list must have table names in it, also raises sensible errors for empty strings, and things which are not strings.