Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preprocessor: improve the macro parameter handling #537

Closed
ForNeVeR opened this issue Jan 29, 2024 · 0 comments · Fixed by #540
Closed

Preprocessor: improve the macro parameter handling #537

ForNeVeR opened this issue Jan 29, 2024 · 0 comments · Fixed by #540
Assignees
@ForNeVeR
Labels
area:preprocessor Related to C preprocessor good-first-issue An issue considered simple enough for new contributors kind:feature New feature or request

Comments

@ForNeVeR
Copy link
Owner

ForNeVeR commented Jan 29, 2024 •
edited
Loading

Our current preprocessor implementation has a somewhat vague block of code that parses the macro parameters. While the easy cases are handled correctly, certain complex ones are not.

See TODO[#537] in the code for my proposal on the improvement (look near CPreprocessor::ReplaceMacrosInLine), and make sure to enable back the corresponding test.

Also, I'm not sure the nested macros are currently processed properly. This is also in the scope of this task / proposal.
@ForNeVeR ForNeVeR added kind:feature New feature or request status:help-wanted Open for contributors area:preprocessor Related to C preprocessor good-first-issue An issue considered simple enough for new contributors labels Jan 29, 2024
ForNeVeR added a commit that referenced this issue Jan 29, 2024
@ForNeVeR
(#537, #538) Preprocessor: connect TODOs with the issues
e7416e0
@ForNeVeR ForNeVeR removed the status:help-wanted Open for contributors label Jan 30, 2024
@ForNeVeR ForNeVeR self-assigned this Jan 30, 2024
ForNeVeR added a commit that referenced this issue Jan 30, 2024
@ForNeVeR
(#537) Preprocessor: basic skeleton for the new macro expansion engine
77ef79f
@ForNeVeR ForNeVeR mentioned this issue Jan 30, 2024
Merged
2 tasks
ForNeVeR added a commit that referenced this issue Feb 1, 2024
@ForNeVeR
(#537) Preprocessor: further steps towards macro expansion
ed87179
ForNeVeR added a commit that referenced this issue Feb 3, 2024
@ForNeVeR
(#537) Preprocessor: support # and ## operators again
1a611db
ForNeVeR added a commit that referenced this issue Feb 3, 2024
@ForNeVeR
(#537) Preprocessor: fix commas in VA_ARGS
d8f2866
ForNeVeR added a commit that referenced this issue Feb 3, 2024
@ForNeVeR
(#537) Preprocessor: emit the right paren finishing certain arguments
a897a34
ForNeVeR added a commit that referenced this issue Feb 4, 2024
@ForNeVeR
(#537) TransactionalLexer now emits warnings instead of throwing exce…
53aa2f8 
…ptions
ForNeVeR added a commit that referenced this issue Feb 4, 2024
@ForNeVeR
(#537) Preprocessor: skip comments when parsing the macro replacement…
32cba7b 
… list
ForNeVeR added a commit that referenced this issue Feb 4, 2024
@ForNeVeR
(#537) Preprocessor: replace macros in the macro replacement list as …
d85f705 
…well
ForNeVeR added a commit that referenced this issue Feb 4, 2024
@ForNeVeR
(#537) Preprocessor: roll back certain space-related changes in the o…
0de1735 
…utput
ForNeVeR added a commit that referenced this issue Feb 4, 2024
@ForNeVeR
(#537) Preprocessor: follow-up on macro substitution rules and order
52375bd
ForNeVeR added a commit that referenced this issue Feb 4, 2024
@ForNeVeR
(#537) Preprocessor: fix the space buffering for ##
1aa8d67
ForNeVeR added a commit that referenced this issue Feb 4, 2024
@ForNeVeR
(#537) Preprocessor: test passing a macro as an argument to another m…
a3f19f5 
…acro
ForNeVeR added a commit that referenced this issue Feb 4, 2024
@ForNeVeR
(#537) Preprocessor: expand macros after substitution
903ea21
ForNeVeR added a commit that referenced this issue Feb 4, 2024
@ForNeVeR
(#537) Preprocessor: extract MacroExpansionEngine into a separate type
a1d854b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ForNeVeR ForNeVeR

Labels
area:preprocessor Related to C preprocessor good-first-issue An issue considered simple enough for new contributors kind:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New macro expansion engine ForNeVeR/Cesium
1 participant
@ForNeVeR