Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preprocessor: fix handling of multi-line macro parameters #538

Closed
Tracked by #77
ForNeVeR opened this issue Jan 29, 2024 · 0 comments · Fixed by #547
Closed
Tracked by #77

Preprocessor: fix handling of multi-line macro parameters #538

ForNeVeR opened this issue Jan 29, 2024 · 0 comments · Fixed by #547
Assignees
@ForNeVeR
Labels
area:preprocessor Related to C preprocessor good-first-issue An issue considered simple enough for new contributors kind:bug Something isn't working

Comments

@ForNeVeR
Copy link
Owner

After merging of #536, the following case has been regressed:

#define MACRO(x) x
MACRO(1
2
3)

Currently it's stored as a test Cesium.Parser.Tests.PreprocessorTests.PreprocessorTests.TestMultilineArgs. Fix it and re-enable the test.
@ForNeVeR ForNeVeR added kind:bug Something isn't working status:help-wanted Open for contributors area:preprocessor Related to C preprocessor good-first-issue An issue considered simple enough for new contributors labels Jan 29, 2024
ForNeVeR added a commit that referenced this issue Jan 29, 2024
@ForNeVeR
(#537, #538) Preprocessor: connect TODOs with the issues
e7416e0
@ForNeVeR ForNeVeR mentioned this issue Feb 10, 2024
Open
29 tasks
@ForNeVeR ForNeVeR self-assigned this Feb 10, 2024
@ForNeVeR ForNeVeR removed the status:help-wanted Open for contributors label Feb 10, 2024
ForNeVeR added a commit that referenced this issue Feb 10, 2024
@ForNeVeR
(#538) Preprocessor: properly parse the multi-line blocks
3f249e0
@ForNeVeR ForNeVeR mentioned this issue Feb 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ForNeVeR ForNeVeR

Labels
area:preprocessor Related to C preprocessor good-first-issue An issue considered simple enough for new contributors kind:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preprocessor: properly parse the multi-line blocks ForNeVeR/Cesium
1 participant
@ForNeVeR