Fix adaptive format picked by video JS sometimes not showing up in quality selector #3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
the
PR: waiting for review
absidue
reviewed
Mar 24, 2023
Co-authored-by: absidue <[email protected]>
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Mar 25, 2023
ChunkyProgrammer
previously approved these changes
Mar 26, 2023
5 tasks
PikachuEXE
dismissed stale reviews from ChunkyProgrammer and efb4f5ff-1298-471a-8973-3d47447115dc
via
0e23cf6
|
@absidue Applied workaround here as you asked |
absidue
reviewed
Apr 1, 2023
absidue
added
PR: changes requested
and removed
PR: waiting for review
Co-authored-by: absidue <[email protected]>
absidue
approved these changes
Apr 1, 2023
absidue
added
PR: waiting for review
ChunkyProgrammer
approved these changes
Apr 1, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Apr 1, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Apr 4, 2023
…tom-builds/current * feature/watch-page/playlist-scroll-to-current: (25 commits) ! Fix window being scrolled when playlist is out of initial view * Update watch view playlist component to auto scroll to current video Bump @babel/preset-env from 7.20.2 to 7.21.4 (FreeTubeApp#3389) Fix trending & search result list rendered items not updated without workaround (FreeTubeApp#3342) Translated using Weblate (Italian) Translated using Weblate (Japanese) Fix adaptive format picked by video JS sometimes not showing up in quality selector (FreeTubeApp#3350) Translated using Weblate (Italian) Remove empty translation strings at build time (FreeTubeApp#3361) Prevent `channelInstance` from being `null` in community tab fallback (FreeTubeApp#3346) Translated using Weblate (Odia) Translated using Weblate (Odia) Translated using Weblate (Odia) Translated using Weblate (Odia) Translated using Weblate (Tigrinya) Translated using Weblate (Odia) Added translation using Weblate (Tigrinya) Added translation using Weblate (Tigre) Import from YouTube history using JSON export (FreeTubeApp#2958) Translated using Weblate (Odia) ... # Conflicts: # src/renderer/views/Watch/Watch.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Not if only happens after #3278, but discovered during testing #3278 anyway
Description
A. Inconsistency in
adaptiveFormatsbetween Local API & Invidious APIUsing Local API & Proxy video through Invidious would cause quality selector issue on some videos
Due to different quality set from Local API and Invidious API
B. Invidious issue on AV1 formats
#3382
This PR has fix for (A) but only workaround for (B) due to it being caused by Invidious issue
Screenshots
Before fix
After fix
Testing
A. Inconsistency in
adaptiveFormatsbetween Local API & Invidious APIB. Invidious issue on AV1 formats
Same as (A) but with https://youtu.be/8IFwpI7OT6I
Desktop
Additional context