Remove empty translation strings at build time #3361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Mar 26, 2023
ChunkyProgrammer
approved these changes
Mar 26, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Apr 1, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Apr 4, 2023
…tom-builds/current * feature/watch-page/playlist-scroll-to-current: (25 commits) ! Fix window being scrolled when playlist is out of initial view * Update watch view playlist component to auto scroll to current video Bump @babel/preset-env from 7.20.2 to 7.21.4 (FreeTubeApp#3389) Fix trending & search result list rendered items not updated without workaround (FreeTubeApp#3342) Translated using Weblate (Italian) Translated using Weblate (Japanese) Fix adaptive format picked by video JS sometimes not showing up in quality selector (FreeTubeApp#3350) Translated using Weblate (Italian) Remove empty translation strings at build time (FreeTubeApp#3361) Prevent `channelInstance` from being `null` in community tab fallback (FreeTubeApp#3346) Translated using Weblate (Odia) Translated using Weblate (Odia) Translated using Weblate (Odia) Translated using Weblate (Odia) Translated using Weblate (Tigrinya) Translated using Weblate (Odia) Added translation using Weblate (Tigrinya) Added translation using Weblate (Tigre) Import from YouTube history using JSON export (FreeTubeApp#2958) Translated using Weblate (Odia) ... # Conflicts: # src/renderer/views/Watch/Watch.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove empty translation strings at build time
Pull Request Type
Related issue
closes #3359
Description
vue-i18n doesn't fallback to en-US if a translation contains an empty string, it does correctly fallback if the translation doesn't exist at all.
Some language files have a lot of empty strings, unfortunately weblate seems to have added those empty strings, so if we remove them in the files, it's possible that weblate will just add them back. Instead I decided to remove them at build time, that way even if weblate adds more empty strings in the future, we won't be affected by it.
Testing
Set the FreeTube language to español (Argentina)/
es_AR, instead of loads of things being unlabelled, they should have the en-US strings.Desktop