Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TxPoolError from fuel-core-types to fuel-core-txpool #2082

Closed
Dentosal opened this issue Aug 14, 2024 · 0 comments · Fixed by #2088
Closed

Move TxPoolError from fuel-core-types to fuel-core-txpool #2082

Dentosal opened this issue Aug 14, 2024 · 0 comments · Fixed by #2088
Assignees
@netrome
Labels
fuel-txpool good first issue Good for newcomers

Comments

@Dentosal
Copy link
Member

Originated from #2080 (comment)
@Dentosal Dentosal mentioned this issue Aug 14, 2024
Merged
5 tasks
@netrome netrome self-assigned this Aug 15, 2024
@netrome netrome mentioned this issue Aug 15, 2024
Merged
5 tasks
@netrome netrome linked a pull request Aug 15, 2024 that will close this issue
refactor: move TxPoolError from fuel-core-types to fuel-core-txpool #2088
Merged
5 tasks
xgreenx added a commit that referenced this issue Aug 16, 2024
@netrome @rymnc @xgreenx
refactor: move TxPoolError from fuel-core-types to fuel-core-txpool (#…
6effb64 
…2088)

## Linked Issues/PRs
- Closes #2082 

## Description
This PR does three things:

1. The `Error` type defined in `crates/types/src/services/txpool.rs` is
moved to `crates/services/txpool/src/error.rs`.
2. This error type now also implements `From<WasmValidityError>`.
3. Refactor to use `derive_more` instead of `thiserror` for the error
type.

## Checklist
- [x] Breaking changes are clearly marked as such in the PR description
and changelog
- [x] New behavior is reflected in tests
- [x] [The specification](https://github.com/FuelLabs/fuel-specs/)
matches the implemented behavior (link update PR if changes are needed)

### Before requesting review
- [x] I have reviewed the code myself
- [x] I have created follow-up issues caused by this PR and linked them
here

---------

Co-authored-by: Aaryamann Challani <[email protected]>
Co-authored-by: Green Baneling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netrome netrome

Labels
fuel-txpool good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move TxPoolError from fuel-core-types to fuel-core-txpool FuelLabs/fuel-core
2 participants
@Dentosal @netrome