Validate WASM on txpool level before allowing upgrade tx #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgreenx
reviewed
Aug 14, 2024
MitchTurner
reviewed
Aug 14, 2024
MitchTurner
reviewed
Aug 14, 2024
| @@ -172,6 +178,16 @@ pub(crate) fn random_predicate( | |||
| .into_default_estimated() | |||
| } | |||
|
|
|||
| pub struct MockWasmChecker; | |||
There was a problem hiding this comment.
nit: I'd name this Fake instead of Mock, since it's not "mocking" behavior.
There was a problem hiding this comment.
The terminology seems to be all over the place, e.g. https://stackoverflow.com/questions/346372/whats-the-difference-between-faking-mocking-and-stubbing shows that there's no consensus around the naming. I don't think we them that consistently either.
xgreenx
reviewed
Aug 15, 2024
5 tasks
xgreenx
reviewed
Aug 15, 2024
xgreenx
approved these changes
Aug 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2078
When submitting an Upgrade tx, validate the WASM before it can be added into the txpool. This is technically a breaking change, as previously-accepted but semantically invalid transactions are no longer accepted.
Checklist
Before requesting review