Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use methods from StorageRead trait in the LDC and copy code opcodes #681

Closed
xgreenx opened this issue Feb 21, 2024 · 1 comment · Fixed by #847
Closed

Use methods from StorageRead trait in the LDC and copy code opcodes #681

xgreenx opened this issue Feb 21, 2024 · 1 comment · Fixed by #847
Assignees
@acerone85
Labels
good first issue Good for newcomers

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Feb 21, 2024

We need to remove storage_contract method and update all places to use StorageRead::read method instead.

image
@MitchTurner MitchTurner added the good first issue Good for newcomers label Sep 19, 2024
@acerone85 acerone85 self-assigned this Sep 24, 2024
@acerone85
Copy link
Contributor

Tentatively assigning myself

@acerone85 acerone85 mentioned this issue Oct 4, 2024
Merged
10 tasks
@acerone85 acerone85 mentioned this issue Nov 14, 2024
Merged
9 tasks
xgreenx added a commit to FuelLabs/fuel-core that referenced this issue Dec 23, 2024
@acerone85 @AurelienFT @xgreenx
Refactor fuel-core to use version of StorageRead::read with offset (F…
d6e4bb9 
…ull update to 0.59.1) (#2438)

## Linked Issues/PRs
<!-- List of related issues/PRs -->

Related to FuelLabs/fuel-vm#681

## Description
In order to load contracts from a given offset efficiently, we have
changed the interface of `StorageRead::read` to accept a n offset in
input (see FuelLabs/fuel-vm#863). This PR
refactors the fuel-core repo to make use of the new StorageRead trait.

## Checklist
- [ ] Breaking changes are clearly marked as such in the PR description
and changelog
- [ ] New behavior is reflected in tests
- [ ] [The specification](https://github.com/FuelLabs/fuel-specs/)
matches the implemented behavior (link update PR if changes are needed)

### Before requesting review
- [ ] I have reviewed the code myself
- [ ] I have created follow-up issues caused by this PR and linked them
here

### After merging, notify other teams

[Add or remove entries as needed]

- [ ] [Rust SDK](https://github.com/FuelLabs/fuels-rs/)
- [ ] [Sway compiler](https://github.com/FuelLabs/sway/)
- [ ] [Platform
documentation](https://github.com/FuelLabs/devrel-requests/issues/new?assignees=&labels=new+request&projects=&template=NEW-REQUEST.yml&title=%5BRequest%5D%3A+)
(for out-of-organization contributors, the person merging the PR will do
this)
- [ ] Someone else?

---------

Co-authored-by: AurelienFT <[email protected]>
Co-authored-by: AurelienFT <[email protected]>
Co-authored-by: AurelienFT <[email protected]>
Co-authored-by: green <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acerone85 acerone85

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@MitchTurner @xgreenx @acerone85