Add the possibility to specify an offset for the read value in StorageRead::read #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acerone85
requested review from
xgreenx,
Dentosal,
MitchTurner and
Voxelot
as code owners
…emory implementation
xgreenx
reviewed
Oct 30, 2024
fuel-storage/src/impls.rs
Outdated
Comment on lines
203
to
206
| key: &<Type as Mappable>::Key, | ||
| buf: &mut [u8], | ||
| ) -> Result<Option<usize>, T::Error> { | ||
| self.0.read(key, buf) | ||
| self.0.read(key, 0, buf) |
There was a problem hiding this comment.
We can specify offset here as well or add read_with_offset=)
There was a problem hiding this comment.
Done here: b2335f9
Is there any reason why StorageRef does not implement StorageRead btw? The only thing I see is that it does not implement StorageSize, which is a requirement for StorageRead.
There was a problem hiding this comment.
It doesn't implement any traits because it is used like storage::<Mapable>().read without importing the trait(just calling of the function). This structure is used as a syntax sugar to simplify the work within the code
fuel-vm/src/storage.rs
Outdated
Comment on lines
36
to
38
| pub use memory::MemoryStorage; | ||
| #[cfg(feature = "test-helpers")] | ||
| pub use memory::MemoryStorageError; |
There was a problem hiding this comment.
Suggested change
| pub use memory::MemoryStorage; | |
| #[cfg(feature = "test-helpers")] | |
| pub use memory::MemoryStorageError; | |
| pub use memory::{ | |
| MemoryStorage, | |
| MemoryStorageError, | |
| }; |
There was a problem hiding this comment.
Changed here: 8855eab
CHANGELOG.md
Outdated
Comment on lines
14
to
15
| - [863](https://github.com/FuelLabs/fuel-vm/pull/863): Changed StorageRead::read to load a serialized value starting from a offset. The function returns an optional value equal to the number of bytes read when defined, or none if the offset specified in input is outside the boundaries of the serialized value read. | ||
| ## [Version 0.58.2] |
There was a problem hiding this comment.
Suggested change
| - [863](https://github.com/FuelLabs/fuel-vm/pull/863): Changed StorageRead::read to load a serialized value starting from a offset. The function returns an optional value equal to the number of bytes read when defined, or none if the offset specified in input is outside the boundaries of the serialized value read. | |
| ## [Version 0.58.2] | |
| - [863](https://github.com/FuelLabs/fuel-vm/pull/863): Changed StorageRead::read to load a serialized value starting from a offset. The function returns an optional value equal to the number of bytes read when defined, or none if the offset specified in input is outside the boundaries of the serialized value read. | |
| ## [Version 0.58.2] |
There was a problem hiding this comment.
Thanks, changed in 5b91da4
Yes, I'll start working on that shortly. IIUC After the release of the next fuel-vm version I'll also have to update |
Yes |
xgreenx
approved these changes
Oct 30, 2024
Dentosal
approved these changes
Nov 9, 2024
Merged
xgreenx
added a commit
to FuelLabs/fuel-core
that referenced
this pull request
Dec 23, 2024
…ull update to 0.59.1) (#2438) ## Linked Issues/PRs <!-- List of related issues/PRs --> Related to FuelLabs/fuel-vm#681 ## Description In order to load contracts from a given offset efficiently, we have changed the interface of `StorageRead::read` to accept a n offset in input (see FuelLabs/fuel-vm#863). This PR refactors the fuel-core repo to make use of the new StorageRead trait. ## Checklist - [ ] Breaking changes are clearly marked as such in the PR description and changelog - [ ] New behavior is reflected in tests - [ ] [The specification](https://github.com/FuelLabs/fuel-specs/) matches the implemented behavior (link update PR if changes are needed) ### Before requesting review - [ ] I have reviewed the code myself - [ ] I have created follow-up issues caused by this PR and linked them here ### After merging, notify other teams [Add or remove entries as needed] - [ ] [Rust SDK](https://github.com/FuelLabs/fuels-rs/) - [ ] [Sway compiler](https://github.com/FuelLabs/sway/) - [ ] [Platform documentation](https://github.com/FuelLabs/devrel-requests/issues/new?assignees=&labels=new+request&projects=&template=NEW-REQUEST.yml&title=%5BRequest%5D%3A+) (for out-of-organization contributors, the person merging the PR will do this) - [ ] Someone else? --------- Co-authored-by: AurelienFT <[email protected]> Co-authored-by: AurelienFT <[email protected]> Co-authored-by: AurelienFT <[email protected]> Co-authored-by: green <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Link to related issue(s) here, if any]
[Short description of the changes.]
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]